[Bug 35306] New: Expired holds are not displayed correctly in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Bug ID: 35306 Summary: Expired holds are not displayed correctly in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 33575 added datatables to the holds table on request.pl - however, it removed the display of 'Expired: mm/dd/yyyy' for expired holds and used a date picker. Flatpickr won't show dates prior to today, so the expiration date is now showing as blank This means that when the holds page is updated, expiration dates are removed from the hold page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 [Bug 33575] Add table settings to the holds table for a specific record in the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Expired holds are not |Expired holds are not |displayed correctly in |displayed correctly in |staff client |staff interface See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34032 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35307 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158805&action=edit Bug 35306: Fix Expired holds when modding request To test: 1. Make some holds on a record and make sure some are set to expired. 2. Go to to reserve/request.pl?biblionumber=X for the biblionumber 3. Try updating something besides the expiration date. i.e. Pickup library 4. Click Update hold(s) 5. Notice the expirated holds have lost their expiration date. 6. APPLY PATCH 7. Try steps 2-4 again, this time the expiration date shold be retained. 8. Make sure Table settings still work and you can properly hide columns. 9. The hold expiration date should be hide-able. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158805|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158812&action=edit Bug 35306: Fix Expired holds when modding request To test: 1. Make some holds on a record and make sure some are set to expired. 2. Go to to reserve/request.pl?biblionumber=X for the biblionumber 3. Try updating something besides the expiration date. i.e. Pickup library 4. Click Update hold(s) 5. Notice the expirated holds have lost their expiration date. 6. APPLY PATCH 7. Try steps 2-4 again, this time the expiration date shold be retained. 8. Make sure Table settings still work and you can properly hide columns. 9. The hold expiration date should be hide-able. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- NOTE: I had a go at testing, but Katron had already signed off. Adding my notes/questions anyway. Hi Lucas. I had a go at testing, but I couldn't figure out from the test plan or description how to set a hold to expired. Do I have to update this in the database? When placing the hold, I can't select a date in the date picker before today, and I can't manually enter it - it remains blank. Also, when I applied the patch, there are now four columns that cannot be toggled: - checkbox - priority - expiration (newly added after the patch was applied) - pickup library In addition, (also before the patch is applied as well), I can't sort on several columns, such as Priority, Change priority, Expiration date. The ones that do seem to work are Patron, Notes, Date, Pickup library, Details. Maybe for some, it doesn't make sense for them to be sortable? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #3)
NOTE: I had a go at testing, but Katron had already signed off. Adding my notes/questions anyway.
Hi Lucas.
I had a go at testing, but I couldn't figure out from the test plan or description how to set a hold to expired.
Do I have to update this in the database?
Yes, you can't create one from the GUI or only by waiting a few days :) I used something like this: update reserves set expirationdate = '2022-01-01', patron_expiration_date = '2022-01-01' where reserve_id = 11;
When placing the hold, I can't select a date in the date picker before today, and I can't manually enter it - it remains blank.
That's the expected behaviour.
Also, when I applied the patch, there are now four columns that cannot be toggled: - checkbox - priority - expiration (newly added after the patch was applied) - pickup library
The change on the expiration date column is intentional.
In addition, (also before the patch is applied as well), I can't sort on several columns, such as Priority, Change priority, Expiration date. The ones that do seem to work are Patron, Notes, Date, Pickup library, Details. Maybe for some, it doesn't make sense for them to be sortable?
That might be something for a separate bug, but it does make some sense. As expiration date can be a text or an input field, it's probably removed from sorting for now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158812|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 158819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158819&action=edit Bug 35306: Fix Expired holds when modding request To test: 1. Make some holds on a record and make sure some are set to expired. 2. Go to to reserve/request.pl?biblionumber=X for the biblionumber 3. Try updating something besides the expiration date. i.e. Pickup library 4. Click Update hold(s) 5. Notice the expirated holds have lost their expiration date. 6. APPLY PATCH 7. Try steps 2-4 again, this time the expiration date shold be retained. 8. Make sure Table settings still work and you can properly hide columns. 9. The hold expiration date should be hide-able. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Katrin! Can now replicate and have added my sign-off as well. David Testing notes (using KTD): 1. Use the SQL query in comment #4 to change the expiration date. 2. Holds that are expired should show in the expiration column as "Expired: XX/XX/XXXX", but just shows the date picker. 3. After applying the patch and refreshing the page, the text with the expired date should now show. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33575 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35306 Bug 35306 depends on bug 33575, which changed state. Bug 33575 Summary: Add table settings to the holds table for a specific record in the staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33575 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org