[Bug 32615] New: Don't crash on empty yaml sysprefs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32615 Bug ID: 32615 Summary: Don't crash on empty yaml sysprefs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org It appears that empty sysprefs will cause C4::Context->yaml_preference to crash. This patch should fix that so that yaml preference values don't cause any issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32615 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 145239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145239&action=edit Bug 32615: Don't crash on empty yaml sysprefs To test: 1) Apply patch 2) Verify tests in t/Context.t pass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32615 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- I now realized it's only when adding a new syspref, setting the initial value to NULL that this is an issue. So very much of an edge case. I still don't see the harm of fixing this, but it's a very minor issue indeed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32615 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Closing this one, I made a mistake testing this and appears undef/null values actually don't cause any issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org