https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Created attachment 71641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71641&action=edit Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71641|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 71658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71658&action=edit Bug 20205 - Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71696&action=edit k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71658|0 |1 is obsolete| | Attachment #71696|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71697&action=edit Bug 20205: Add IDs to buttons in patron-toolbar.inc The buttons in patron-toolbar.inc lack unique IDs, making them hard to style/remove with CSS. This patch adds IDs to all three buttons. To test: - Look in koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc and verify there are no IDs - Apply the patch and look at the file again to verify the IDs have been added - Test the "New patron" and "Quick add new patron" buttons to verify they still work as intended - Check that the new buttons are globally unique: $ grep -rn "new-patron-button" * $ grep -rn "patron-lists-button" * Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20205 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.