[Bug 19687] New: Recent upgrade to 17.05.04.000 bulkmarcimport started to fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Bug ID: 19687 Summary: Recent upgrade to 17.05.04.000 bulkmarcimport started to fail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: mtj@kohaaloha.com QA Contact: testopia@bugs.koha-community.org After recent upgrade to 17.05.04.000 bulkmarcimport started to fail on all items attempted to be added. ERROR: Adding items to bib 1 failed: Undefined subroutine &C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line 382, <GEN46> line 1 So I manually added the prefix and the next error came up: ERROR: Adding items to bib 74925 failed: Undefined subroutine &C4::Items::GetMarcStructure called at /usr/share/koha/lib/C4/Items.pm line 2307, <GEN46> line 14. Manually adding the prefix to that line seems to have worked, but it does not feel like the right solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 [Bug 18927] koha-rebuild-zebra is failing with "error retrieving biblio" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #1 from Ian Bays <ian.bays@ptfs-europe.com> --- Also the command line commit (after stage) has similar issues: Undefined subroutine &C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line 243. /usr/share/koha/bin/commit_file.pl --batch-number 5 ... importing MARC records -- please wait Undefined subroutine &C4::Items::ModZebra called at /usr/share/koha/lib/C4/Items.pm line 302. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is evil, someone working on a fix? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- How do you run the command? Which version of perl? Which OS? I do not recreate with perl misc/migration_tools/bulkmarcimport.pl -b --file koha.mrc on Debian 8.10 with perl v5.20.2 If you have a patch that fixes your issue, please submit it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing without items bulkmarcimport seems to mostly work (apart from the update option, see bug 20811). I also tested with a record exported from Koha with 3 items: /home/vagrant/kohaclone/misc$ ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action replace --add-items ... staging MARC records -- please wait ... finished staging MARC records ... looking for matches with records already in database Invalid normalization routine required (Biblionumber) at /home/vagrant/kohaclone/C4/Matcher.pm line 874. ... finished looking for matches MARC record staging report ------------------------------------ Input file: ../data/bib-69.utf8 Record type: biblio Number of input records: 1 Number of valid records: 1 Number of invalid records: 0 Number of records matched: 1 Number of items parsed: 3 Batch number assigned: 2 kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc$ ./commit_file.pl --batch-number 2 ... importing MARC records -- please wait ... finished importing MARC records MARC record import report ---------------------------------------- Batch number: 2 Number of new records added: 0 Number of records replaced: 1 Number of records ignored: 0 Number of items added: 0 Number of items replaced: 3 Number of items ignored: 0 Then I deleted the record and tried another import: ./stage_file.pl --match 3 --file ../data/bib-69.utf8 --item-action always_add --add-items ./commit_file.pl --batch-number 4 Record and items were added. Tested on master. I think we need more information to track this problem down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #5 from Ian Bays <ian.bays@ptfs-europe.com> --- For the bulkmarcimport error: install is a "standard install" at version 17.11.04.000 Command line used: ~/kohaclone/misc/migration_tools/bulkmarcimport.pl -file Results/$x.mrc -v > Logs/$x.txt Repeating error is: ERROR: Adding items to bib 4026 failed: Undefined subroutine &C4::Items::TransformMarcToKoha called at /usr/share/koha/lib/C4/Items.pm line 379, <GEN46> line 4026. Koha About information: Koha version: 17.11.04.000 OS version ('uname -a'): Linux ncol.dh.bytemark.co.uk 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 Perl interpreter: /usr/bin/perl Perl version: 5.024001 Perl @INC: /usr/share/koha/lib /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base MySQL version: mysql Ver 15.1 Distrib 10.1.26-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #6 from Ian Bays <ian.bays@ptfs-europe.com> --- The commit error was on the same system at the same version with the commit line described earlier. If it helps the stage command used was: /usr/share/koha/bin/stage_file.pl --file Results/ncol_bib.mrc --match 1 --add-items --item-action always_add --no-replace where match 1 is match on ISBN and aggressive ISBN matching is turned on. PERL5LIB is: echo $PERL5LIB /usr/share/koha/lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ian and others, we have run several tests with 17.11.07 as we plan to update soon and could not see any errors. We are using a package installation with Debian. The problem could only exist in 17.05 or there is another difference we haven't figured out yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lowering severity until we have more information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #9 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Aren't "just" prefixes missing? (C4::Biblio::) We are having the same problem with Undefined subroutine &C4::Items::TransformMarcToKoha called at /home/koha/src/C4/Items.pm line 243. On a 17.11.06 on a Debian 8 with perl v5.20.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #10 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- An hypothesis from a colleague is that there might be some circular dependency that prevents the prefixless-resolution to work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Probably caused by circular dependencies and incorrect use of Exporter (https://www.perlmonks.org/?node_id=778639). I have tried moving the exports so appears before other module imports in C4/Biblio.pm and seams to solve the problem. I will try to prepare a patch for this and create a separate issue, probably today or tomorrow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Created attachment 79435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79435&action=edit Bug 19687: Undefined subroutine in bulkmarcimport Bulkmarcimport produces undefined subroutine error for C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure probably caused by mutually recursive modules. Put exports in BEGIN clause before all the other imports. 1) Run bulkmarcimport.pl before applying patch and verify that undefined subroutine error occurs 2) Apply patch 3) Run bulkmarcimport.pl again and verify that no errors are produced Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- I decided to attach the patch to this issue instead of creating a new. Have not had time to test it for the bulkmarcimport-case but this solved the exact same issue I was having with a plugin. My current koha-setup is a little bit broken with regards to bulkmarcimport, so if anyone could test if this fixes the problem there also that would be great. Can test this myself eventually, but will probably be a couple of days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79435|0 |1 is obsolete| | --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- Created attachment 79436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79436&action=edit Bug 19687: Undefined subroutine in bulkmarcimport Bulkmarcimport produces undefined subroutine error for C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure probably caused by mutually recursive modules. Put exports in BEGIN clause before all the other imports. To test: 1) Run bulkmarcimport.pl before applying patch and verify that undefined subroutine error occurs 2) Apply patch 3) Run bulkmarcimport.pl again and verify that no errors are produced Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 George Veranis <gveranis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis@gmail.com --- Comment #15 from George Veranis <gveranis@gmail.com> --- I apply your patch on Koha version: 18.05.04.000 OS version ('uname -a'): Linux Debian-95-stretch-64-minimal 4.9.0-7-amd64 #1 SMP Debian 4.9.110-1 (2018-07-05) x86_64 Perl version: 5.024001 and it works ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi George, would you like to add your sign off and set this to 'Signed off' then? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 George Veranis <gveranis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 --- Comment #17 from George Veranis <gveranis@gmail.com> --- I try to sign-off this patch on koha-sandbox but the patch not apply. So I changed the status. I apply the patch on my koha manually and the bug solved. I try maybe to rewrite the patch later. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79436|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80276&action=edit Bug 19687: Undefined subroutine in bulkmarcimport Bulkmarcimport produces undefined subroutine error for C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure probably caused by mutually recursive modules. Put exports in BEGIN clause before all the other imports. To test: 1) Run bulkmarcimport.pl before applying patch and verify that undefined subroutine error occurs 2) Apply patch 3) Run bulkmarcimport.pl again and verify that no errors are produced Sponsored-by: Gothenburg University Library Signed-off-by: George Veranis <gveranis@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch applies ok for me, I have attached your signed-off-by line to the patch. I let you adjust the status to Signed Off to get the credit :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 George Veranis <gveranis@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from George Veranis <gveranis@gmail.com> --- Thanks, next time I will manage it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80276|0 |1 is obsolete| | --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80314&action=edit Bug 19687: Undefined subroutine in bulkmarcimport Bulkmarcimport produces undefined subroutine error for C4::Items::TransformMarcToKoha and C4::Items::GetMarcStructure probably caused by mutually recursive modules. Put exports in BEGIN clause before all the other imports. To test: 1) Run bulkmarcimport.pl before applying patch and verify that undefined subroutine error occurs 2) Apply patch 3) Run bulkmarcimport.pl again and verify that no errors are produced Sponsored-by: Gothenburg University Library Signed-off-by: George Veranis <gveranis@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Does not apply easily on 17.11.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org