[Bug 35188] New: force_checkout permission can override all blocks on a patron account but only shows when they are restricted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Bug ID: 35188 Summary: force_checkout permission can override all blocks on a patron account but only shows when they are restricted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When the force_checkout permission was added, the script circulation.pl was altered to allow overriding any block on the patron's account (expired, gonenoaddress, etc) The last follow-up on that bug, however, moved the button to override into the section for restrictions, limiting the scope for users to the case where a patron had a debarment. To recreate: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions I think the intent here should be that 'force_checkout' allows overriding any of the statuses -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158062&action=edit Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |katrin.fischer@bsz-bw.de Depends on| |643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643 [Bug 643] Allow override of 'debarred' status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crose@mercantilelibrary.com --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 34588 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158062|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 158271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158271&action=edit Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158271|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 158413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158413&action=edit Bug 35188: Show checkout override for all noisseus statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 23.05.x Please provide rebased patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158803&action=edit Bug 35188: [23.05.x] Show checkout override for all noissues statuses This patch moves the override button up one level into the list of noissues in order to allow overriding any blocking status To test: 1 - Log in to Koha with a user with force_checkout permission (superlibrarian ok too) 2 - Mark a patron as expired, lost card, gone no address 3 - Go to 'Check out' page for the patorn 4 - Note you cannot override the restrictions 5 - Add a manual restriction/debarment 6 - Go to checkout again, now you can override 7 - Remove the debarment 8 - Add manually ot URL of checkout page '&foreallow=1' 9 - Note you can now override the other restrictions 10 - Apply patch 11 - Reload patron 12 - Note you now see the override button on the check out screen 13 - Add a debarment 14 - Confirm the button is still there 15 - Confirm overriding allows the checkout (with or without a debarment) Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37703 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35188 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42329 [Bug 42329] Staff can check out to patrons with fines over NoIssuesCharge when AllowFineOverride set to Don't Allow -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org