[Bug 33647] New: Display borrowers.lastseen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Bug ID: 33647 Summary: Display borrowers.lastseen Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: klas.blomberg@skovde.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It would be nice if borrower.lastseen could be displayed at Patron details / Library use. Sometimes it gives a clue why a borrower who doesn't circulate anything is still active -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #1 from Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> --- Circulation Staff would really like to see this. lastseen has much more value to them than Last Updated. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #2 from George Williams (NEKLS) <george@nekls.org> --- +1 - this would be a nice feature -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #3 from Lari Strand <lmstrand@gmail.com> --- Created attachment 185382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185382&action=edit Bug 33647: Display borrowers.lastseen on patronbriefinfo To test: 1. Apply patch 2. Check the top left corner patron info for a new element after Updated on field called patronlastseenon, note that if patron has no lastseen date, atfer the text Last seen on there is no date/time data visible -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.05 |Main CC| |lmstrand@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lmstrand@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185382|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185402&action=edit Bug 33647: Display borrowers.lastseen on patronbriefinfo Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185403&action=edit Bug 33647: (follow-up) Don't try to show last seen info if there is none -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #6 from Lari Strand <lmstrand@gmail.com> --- In my patch the idea was to let the user know when patron has never used the account in a visual way in the element. What if we showed this somehow like: "Last seen on: never" or something like that instead? Maybe use : syntax with updated on too for uniformity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lari Strand from comment #6)
"Last seen on: never" or something like that instead?
That makes sense to me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #8 from Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> --- (In reply to Owen Leonard from comment #7)
(In reply to Lari Strand from comment #6)
"Last seen on: never" or something like that instead?
That makes sense to me
Same here. Circulation staff would know instantly that there's been no activity, instead of possibly wondering why the field isn't there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display borrowers.lastseen |Display borrowers.lastseen | |in patron record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #9 from Lari Strand <lmstrand@gmail.com> --- Created attachment 185535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185535&action=edit Bug 33647: (follow-up) Add UI improvements Use colon for Updated on and Last seen on texts If lastseen value doesn't exist, show the text 'Never' in UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just wondering about older databases or databases where the feature is turned off. 2 suggestions: 1) Could we use "not recorded" or similar when there is no date? 2) Should we make the display of the data dependent on the feature being turned on? (at least one trigger active) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #11 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187223&action=edit Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked This follow-up implements these suggestions: A. Uses 'not recorded' instead of never when there is no date. B. Only shows lastseen if syspref TrackLastPatronActivityTriggers has at least one trigger. To test: 1. Apply patch 2. Ensure syspref TrackLastPatronActivityTriggers has no triggers set. 3. Check patron record top left corner to verify lastseen is not shown. 4. Change system TrackLastPatronActivityTriggers to trigger on Checking out an item. 5. Recheck patron record top left corner to verify lastseen says "not recorded". 6. Check out a book to patron 7. Recheck patron record top left corner to verify there is a date and time shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |If the system preference submission| |TrackLastPatronActivityTrig | |gers has any triggers | |enabled, a patron's 'last | |seen' date will be | |displayed in their patron | |record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187223|0 |1 is obsolete| | --- Comment #12 from Bernard <bernard.scaife@openfifth.co.uk> --- Created attachment 188925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188925&action=edit Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked This follow-up implements these suggestions: A. Uses 'not recorded' instead of never when there is no date. B. Only shows lastseen if syspref TrackLastPatronActivityTriggers has at least one trigger. To test: 1. Apply patch 2. Ensure syspref TrackLastPatronActivityTriggers has no triggers set. 3. Check patron record top left corner to verify lastseen is not shown. 4. Change system TrackLastPatronActivityTriggers to trigger on Checking out an item. 5. Recheck patron record top left corner to verify lastseen says "not recorded". 6. Check out a book to patron 7. Recheck patron record top left corner to verify there is a date and time shown. Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bernard.scaife@openfifth.co | |.uk --- Comment #13 from Bernard <bernard.scaife@openfifth.co.uk> --- All tested and working as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185402|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189530&action=edit Bug 33647: Display borrowers.lastseen on patronbriefinfo Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185403|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189531&action=edit Bug 33647: (follow-up) Don't try to show last seen info if there is none Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185535|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189532&action=edit Bug 33647: (follow-up) Add UI improvements Use colon for Updated on and Last seen on texts If lastseen value doesn't exist, show the text 'Never' in UI Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188925|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189533&action=edit Bug 33647: (follow-up) Wording update & only show lastseen if activity is tracked This follow-up implements these suggestions: A. Uses 'not recorded' instead of never when there is no date. B. Only shows lastseen if syspref TrackLastPatronActivityTriggers has at least one trigger. To test: 1. Apply patch 2. Ensure syspref TrackLastPatronActivityTriggers has no triggers set. 3. Check patron record top left corner to verify lastseen is not shown. 4. Change system TrackLastPatronActivityTriggers to trigger on Checking out an item. 5. Recheck patron record top left corner to verify lastseen says "not recorded". 6. Check out a book to patron 7. Recheck patron record top left corner to verify there is a date and time shown. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Documentation|If the system preference | submission|TrackLastPatronActivityTrig | |gers has any triggers | |enabled, a patron's 'last | |seen' date will be | |displayed in their patron | |record. | Text to go in the| |If the system preference release notes| |TrackLastPatronActivityTrig | |gers has no triggers | |enabled, a patron's 'last | |seen' date will be | |displayed in their patron | |record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 --- Comment #19 from Lari Strand <lmstrand@gmail.com> --- Shouldn't this: Text to go in the release notes: If the system preference TrackLastPatronActivityTriggers has no triggers enabled, a patron's 'last seen' date will be displayed in their patron record. be: Text to go in the release notes: If the system preference TrackLastPatronActivityTriggers HAS triggers enabled, a patron's 'last seen' date will be displayed in their patron record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Text to go in the|If the system preference |If the system preference release notes|TrackLastPatronActivityTrig |TrackLastPatronActivityTrig |gers has no triggers |gers has triggers enabled, |enabled, a patron's 'last |a patron's 'last seen' date |seen' date will be |will be displayed in their |displayed in their patron |patron record. |record. | --- Comment #20 from Aude Charillon <aude.charillon@openfifth.co.uk> --- (In reply to Lari Strand from comment #19)
Shouldn't this:
Text to go in the release notes: If the system preference TrackLastPatronActivityTriggers has no triggers enabled, a patron's 'last seen' date will be displayed in their patron record.
be:
Text to go in the release notes: If the system preference TrackLastPatronActivityTriggers HAS triggers enabled, a patron's 'last seen' date will be displayed in their patron record.
I agree. It's too late now for the published 25.11 release notes, but I am amending the "Text to go in the release notes" anyway (it's useful for a quick glance at the bug). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33647 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #21 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org