[Bug 35862] New: Display patron search result on the right of the form (modal)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Bug ID: 35862 Summary: Display patron search result on the right of the form (modal) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 35329
From bug 35329 comment 59
Next comment.. could we perhaps put the results next to rather than under the filters form in the modal?
It feels odd to have so much whitespace in the modal and have the actual useful content almost hidden off screen.. widescreen aspect ratios are pretty common these days?
Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 [Bug 35329] Move patron searches to a modal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 35846 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162858&action=edit Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch Version|unspecified |23.11 CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162858|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 162862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162862&action=edit Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is a huge improvement, thanks Lucas. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Do we want the 100% width for inputs/select on small screens? https://snipboard.io/iwo0lI.jpg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5)
Do we want the 100% width for inputs/select on small screens? https://snipboard.io/iwo0lI.jpg
It's a good question. I personally think so. But I am happy to change it if we don't think that will be well received. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like the 100% myself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162862|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 162959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162959&action=edit Bug 35862: Display modal search results to the right of form above 1200px To test: 1. Apply patch 2. Rebuild CSS ( yarn build ) 3. Look at some of the places where there is a modal patron search. -suggestion/suggestion.pl: Set to patron -members/memberentry.pl: Add guarantor 4. Make sure the modal looks good before and after you have searched for a patron. 5. Play with many different screen sizes, ensuring everything looks good and makes sense. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This one appears to break the patron_search selenium tests.. I'm working on the resolution now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- False alarm.. it's actually bug 35362 that breaks the test (and the functionality too) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166687&action=edit Bug 35862: Remove dup aside node The aside element is now a parent of the form block, in patron-search.inc (BLOCK patron_search_filters). On members/members-home.pl there were 2 nested aside -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166688&action=edit Bug 35862: Fix patron_search_form selection We were no longer getting a match here and so ended up with 2 forms on the budget page (where we have two modals for patron: owner and users). Caught be selenium tests patrons_search.t : Error while executing command: element not interactable: Element <a class="patron_name patron_preview" href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=511"> could not be scrolled into view It fixes the following UI issues: When you open a modal, start a search, close the modal open the other modal search: the results from the other modal were shown -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked the 2 follow-up patches for inclusion in main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35329 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35862 Bug 35862 depends on bug 35329, which changed state. Bug 35329 Summary: Move patron searches to a modal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35329 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org