http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6790 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-08-26 15:57:21 UTC --- Created attachment 5161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5161 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6790 --- Comment #2 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-08-27 10:03:19 UTC --- Your patch use an unsupported form of template style, that may cause problem in translation processing. In 'serials/routing.tt', you wrote: <option[%- IF r == member.ranking -%] selected="selected"[% END %] value="[% r %]">[% r %]</option> The "IF" directive is *in* tag 'option': this kind of construction is unsupported. (but not problem when directive are in attribute, like 'r' with the 'value' attribute). Your should use instead of: [% IF r == member.ranking %] <option selected="selected" value="[% r %]">[% r %]</option> [% ELSE %] <option value="[% r %]">[% r %]</option> [% END %] For more detail about this problem, please see bug 6458. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6790 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:16 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6790 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5217|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-31 07:27:48 UTC --- Created attachment 6990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6990 Bug 6790: Remove unnecessary variable from getroutinglist return getroutinglist returns a count variable to indicate how many elements are in the array. This is almost always a serious code smell. (We are programming in a list manipulating language) The routine was executing am unnecessary loop just to maintain that var. Removed the variable from the routine and perldoc refactored calls of the routine removed the c-style loops for more idiomatic and maintainable for loops renamed some opaquely named variables removed a call to the routine where nothing was done with the data moved some html out of the calling script and into the template Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6790 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> 2012-01-21 16:22:51 UTC --- Removes for loops in favour of foreach. Does some minor cleanup to quotes and spacing to clean various coding style violations. Looks solid, marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.