[Bug 42988] New: Saving a sip account imported from SIPconfig.xml can change the holds ( holds_get_captured ) behavior.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Bug ID: 42988 Summary: Saving a sip account imported from SIPconfig.xml can change the holds ( holds_get_captured ) behavior. Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- The migration from the SIP config file to the database leaves holds_get_captured NULL which makes the behavior default to on, but in the sip account editor, the off option is selected so when you save the profile edit, the behavior is changed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201560&action=edit Bug 42988: Update database, set holds_get_captured default to 1 The migration from SIPconfig.xml to the database ( bug 37893 ) leaves holds_get_captured NULL for any account that didn't define it in the config file. At SIP checkin an unset holds_get_captured defaults to on, but the REST API returns NULL boolean columns as false, so the SIP account editor shows "No" selected. Saving the account without touching the option then stores 0 and holds are no longer captured at SIP checkin. This patch changes the column default to 1 and sets existing NULL values to 1 so the stored value matches the actual checkin behavior. Test Plan: 1) If you have no SIP accounts, create one 2) Simulate an account migrated from a SIPconfig.xml that doesn't define holds_get_captured: UPDATE sip_accounts SET holds_get_captured = NULL; 3) Edit the account, note "Holds get captured" shows "No" even though holds *are* captured at SIP checkin while the value is unset 4) Apply this patch 5) Run updatedatabase.pl 6) SELECT login_id, holds_get_captured FROM sip_accounts; 7) Note holds_get_captured is now 1! 8) Edit the account again, note "Yes" is now selected for "Holds get captured"! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201561&action=edit Bug 42988: Default holds_get_captured to yes for new SIP accounts The account editor preselects "No" for "Holds get captured" when creating a new SIP account, but the SIP checkin default is to capture holds. This patch makes the editor default the option to "Yes" so a new account behaves the same as one that never set the option. Test Plan: 1) Apply this patch 2) yarn js:build 3) Restart all the things! 4) Create a new account in the SIP2 administration module 5) Note "Holds get captured" defaults to "Yes"! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201562&action=edit Bug 42988: Update Schema files [DO NOT PUSH] Patch from commit 0ade0bf -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201560|0 |1 is obsolete| | Attachment #201561|0 |1 is obsolete| | Attachment #201562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 202164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202164&action=edit Bug 42988: Update database, set holds_get_captured default to 1 The migration from SIPconfig.xml to the database ( bug 37893 ) leaves holds_get_captured NULL for any account that didn't define it in the config file. At SIP checkin an unset holds_get_captured defaults to on, but the REST API returns NULL boolean columns as false, so the SIP account editor shows "No" selected. Saving the account without touching the option then stores 0 and holds are no longer captured at SIP checkin. This patch changes the column default to 1 and sets existing NULL values to 1 so the stored value matches the actual checkin behavior. Test Plan: 1) If you have no SIP accounts, create one 2) Simulate an account migrated from a SIPconfig.xml that doesn't define holds_get_captured: UPDATE sip_accounts SET holds_get_captured = NULL; 3) Edit the account, note "Holds get captured" shows "No" even though holds *are* captured at SIP checkin while the value is unset 4) Apply this patch 5) Run updatedatabase.pl 6) SELECT login_id, holds_get_captured FROM sip_accounts; 7) Note holds_get_captured is now 1! 8) Edit the account again, note "Yes" is now selected for "Holds get captured"! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 202165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202165&action=edit Bug 42988: Default holds_get_captured to yes for new SIP accounts The account editor preselects "No" for "Holds get captured" when creating a new SIP account, but the SIP checkin default is to capture holds. This patch makes the editor default the option to "Yes" so a new account behaves the same as one that never set the option. Test Plan: 1) Apply this patch 2) yarn js:build 3) Restart all the things! 4) Create a new account in the SIP2 administration module 5) Note "Holds get captured" defaults to "Yes"! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 202166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202166&action=edit Bug 42988: Update Schema files [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|Saving a sip account |Saving a SIP account |imported from SIPconfig.xml |imported from SIPconfig.xml |can change the holds ( |can change the holds (Holds |holds_get_captured ) |get captured - |behavior. |holds_get_captured) | |behavior -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov GIT URL| |42778 CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42778 GIT URL|42778 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202164|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202165|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 202705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202705&action=edit Bug 42988: Update database, set holds_get_captured default to 1 The migration from SIPconfig.xml to the database ( bug 37893 ) leaves holds_get_captured NULL for any account that didn't define it in the config file. At SIP checkin an unset holds_get_captured defaults to on, but the REST API returns NULL boolean columns as false, so the SIP account editor shows "No" selected. Saving the account without touching the option then stores 0 and holds are no longer captured at SIP checkin. This patch changes the column default to 1 and sets existing NULL values to 1 so the stored value matches the actual checkin behavior. Test Plan: 1) If you have no SIP accounts, create one 2) Simulate an account migrated from a SIPconfig.xml that doesn't define holds_get_captured: UPDATE sip_accounts SET holds_get_captured = NULL; 3) Edit the account, note "Holds get captured" shows "No" even though holds *are* captured at SIP checkin while the value is unset 4) Apply this patch 5) Run updatedatabase.pl 6) SELECT login_id, holds_get_captured FROM sip_accounts; 7) Note holds_get_captured is now 1! 8) Edit the account again, note "Yes" is now selected for "Holds get captured"! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 202706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202706&action=edit Bug 42988: Default holds_get_captured to yes for new SIP accounts The account editor preselects "No" for "Holds get captured" when creating a new SIP account, but the SIP checkin default is to capture holds. This patch makes the editor default the option to "Yes" so a new account behaves the same as one that never set the option. Test Plan: 1) Apply this patch 2) yarn js:build 3) Restart all the things! 4) Create a new account in the SIP2 administration module 5) Note "Holds get captured" defaults to "Yes"! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #9 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 202707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202707&action=edit Bug 42988: Update Schema files [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #10 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42988 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.03 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org