[Bug 29257] New: Redundant slash in the URL appear during item level hold placing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Bug ID: 29257 Summary: Redundant slash in the URL appear during item level hold placing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andriiverem@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com After placing hold user is redirected to a link containing a redundant slash in the end, which leads to unexpected consequences. Steps to reproduce: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber); E.g.: request.pl?biblionumbers=233/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andriiverem@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 --- Comment #1 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 126409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126409&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126409|0 |1 is obsolete| | --- Comment #2 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 126410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126410&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter; E.g.: request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126410|0 |1 is obsolete| | --- Comment #3 from Andrii Veremeienko <andriiverem@gmail.com> --- Created attachment 126411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126411&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrii Veremeienko <andriiverem@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29259 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29259 [Bug 29259] Url contains slash '/' instead of encoded slash '%2F' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126411|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 126412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126412&action=edit Bug 29257: Redundant slash in the URL appear during item level hold placing The solution was to get rid of adding slash to $biblionumbers directly and join slash only in place when it's needed. How to test: 1. Search for an item; 2. Select single item, click 'Place hold'; 3. Enter a patron card number; 4. Complete hold placing by clicking 'Place hold'; 5. Note that after redirection to URL ended with slash (after biblionumber): e.g.: `request.pl?biblionumbers=233/` 6. Apply the patch 7. Repeat steps 1-4 8 Note that after redirection to the page with hold list, URL doesn't contain slash after biblionumber parameter: e.g.: `request.pl?biblionumbers=233 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I haven't looked into this in-depth, but I'm wary of this one, especially in the context of item-specific multi-holds. I'm not going to look into it right now, but just sharing my thoughts. It would be worth expanding this test plan to different hold scenarios. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28782 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
I haven't looked into this in-depth, but I'm wary of this one, especially in the context of item-specific multi-holds.
I'm not going to look into it right now, but just sharing my thoughts. It would be worth expanding this test plan to different hold scenarios.
I've taken a bit more of a look in light of bug 28782, and it looks the slashes are only important for the OPAC and not for the Staff Interface, so my objection withdrawn. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #7 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Just noting down here as well, if bug 28782 gets pushed then this bug is fixed as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #7)
Just noting down here as well, if bug 28782 gets pushed then this bug is fixed as well.
Yes, I think we should favor bug 28782's solution over this one. Or we based it on top of this one to make this patch backportable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29257 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Will be fixed globally on bug 28782. *** This bug has been marked as a duplicate of bug 28782 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org