[Bug 27188] New: Show current class in plugins home
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Bug ID: 27188 Summary: Show current class in plugins home Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In plugins home, when searching on a specific class, you see the table but no reminder which class is displayed. Only when there are no results you see it in message. I propose to show it in H1 title and remove it from no results message. Sort of what is asked in Bug 16391. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16391 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 114297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114297&action=edit Bug 27188: Show current class in plugins home In plugins home, when searching on a specific class, you see the table but no reminder which class is displayed. Only when there are no results you see it in message. I propose to show it in H1 title and remove it from no results message. Sort of what is asked in Bug 16391. This change adds missing specific message to class 'ill_availability_services'. This change removed the message 'Unknown plugin type'. Seems useless to me since you must change manually method in URL to get it. And this may be usefull for unlisted classes like hooks 'opac_js', ... Test plan : 1) Enable plugins 2) Install a tool plugin like InLibro Carrousel 3) Go to Administration > Manage plugins 4) Check you see the plugin and title 'All plugins' 5) In menu select 'View tool plugins' 6) Check you see the plugin and title 'Plugins that can be used as a tool' 7) In menu select 'View report plugins' 6) Check you see message 'No plugins installed' and title 'Plugins that can create a report' 7) Edit URL and go to /cgi-bin/koha/plugins/plugins-home.pl?method=opac_js 8) Check you see message 'No plugins installed' and title 'Plugins with class opac_js' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I don't like that this uses the button toolbar to switch views, based on my conception of our conventions of views and actions: https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions I would prefer that the views be links in the sidebar or some kind of DataTables filter. I think it's not ideal that one is offered choices to view classes of plugins for which there are no results. This would be an advantage of making the table a DataTable, including the class as a (hidden?) column, and offering table filtering based on the available classes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed changing to a DataTable whould be great.
including the class as a (hidden?) column, and offering table filtering based on the available classes. Just we must remind that a plugin may have several classes.
Thanks for your advice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33336 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the page/table have changed since, any chance to revive? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27188 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #2)
I don't like that this uses the button toolbar to switch views, based on my conception of our conventions of views and actions:
https://wiki.koha-community.org/wiki/Interface_patterns#Views_and_Actions
I would prefer that the views be links in the sidebar or some kind of DataTables filter.
I think it's not ideal that one is offered choices to view classes of plugins for which there are no results. This would be an advantage of making the table a DataTable, including the class as a (hidden?) column, and offering table filtering based on the available classes.
This is the best solution so I close this one invalid. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org