https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | CC| |josef.moravec@gmail.com Status|NEW |ASSIGNED Depends on| |19908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 [Bug 19908] Password should not be mandatory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70244&action=edit Bug 19907: Fix email validation in patron edit form Test plan: 0) Confirm that email validation is not working in add/edit patron form 1) Apply the patch 2) Edit/add patron, the e-mail validation should be working now 3) Ensure the password validation is still working (use test plan from bug 19908) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Jon Knight <J.P.Knight@lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |J.P.Knight@lboro.ac.uk --- Comment #2 from Jon Knight <J.P.Knight@lboro.ac.uk> --- Tried to apply the patch to an up-to-date kohadevbox but it fails: vagrant@kohadevbox:kohaclone(master)$ git fetch vagrant@kohadevbox:kohaclone(master)$ git rebase origin/master Current branch master is up to date. vagrant@kohadevbox:kohaclone(master)$ git checkout -b bug_19907 Switched to a new branch 'bug_19907' vagrant@kohadevbox:kohaclone(bug_19907)$ git bz apply 19907 Bug 19907 - Email validation on patron add/edit not working 70244 - Bug 19907: Fix email validation in patron edit form Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19907: Fix email validation in patron edit form Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 19907: Fix email validation in patron edit form The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19907-Fix-email-validation-in-patron-edit-form-LYJrg8.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 --- Comment #3 from Jon Knight <J.P.Knight@lboro.ac.uk> --- (In reply to Jon Knight from comment #2)

Tried to apply the patch to an up-to-date kohadevbox but it fails:

Ignore me - I didn't notice the dependency on 19908. However as that bug currently has an issue with not requiring the second entry of the password, should testing this patch wait until that is fixed? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Depends on a report that is in ASSIGNED Changing status -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70244|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 73457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73457&action=edit Bug 19907: Fix email validation in patron edit form Test plan: 0) Confirm that email validation is not working in add/edit patron form 1) Apply the patch 2) Edit/add patron, the e-mail validation should be working now 3) Ensure the password validation is still working (use test plan from bug 19908) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73457|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73459&action=edit Bug 19907: Fix email validation in patron edit form Test plan: 0) Confirm that email validation is not working in add/edit patron form 1) Apply the patch 2) Edit/add patron, the e-mail validation should be working now 3) Ensure the password validation is still working (use test plan from bug 19908) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73459|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73463&action=edit Bug 19907: Fix email validation in patron edit form Test plan: 0) Confirm that email validation is not working in add/edit patron form 1) Apply the patch 2) Edit/add patron, the e-mail validation should be working now 3) Ensure the password validation is still working (use test plan from bug 19908) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Bug 19907 depends on bug 19908, which changed state. Bug 19908 Summary: Password should not be mandatory https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depending on Bug 19908 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.