[Bug 27212] New: Add column configuration to the acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Bug ID: 27212 Summary: Add column configuration to the acquisitions home page Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org It would be helpful to be able to hide columns from the accounts table when viewing available funds on acqui-home.pl We're a single site library so we don't need the library column and we don't use the owner column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114401&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114401|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114402&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- There are probably some columns here that should not be able to be hidden and someone smarter than me can probably tell me which columns those are. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114402|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 114412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114412&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Lucas, this patch does seem to make some unexpected changes: 1) We have 2 new columns Budget period description and Active (with 1 and 0) visible, that have been hidden before and only used for sorting and other table functionality etc. 2) The totals are no longer being calculated at all. 3) QA script fails: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt OK filters FAIL forbidden patterns forbidden pattern: tab char (line 208) forbidden pattern: tab char (line 209) forbidden pattern: tab char (line 210) forbidden pattern: tab char (line 211) forbidden pattern: tab char (line 212) forbidden pattern: tab char (line 213) forbidden pattern: tab char (line 214) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114412|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130128&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130128|0 |1 is obsolete| | --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 130773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130773&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This time around, No regressions found! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130773|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132274&action=edit Bug 27212: Add Table configuration to acqui-home.pl accounts table To test, apply the patch and clear your browser cache 1. Go to acqui-home.pl 2. Test that the "Columns" button works to show and hide columns. 3. Go to Administration -> Table settings and look under the Acquisitions tab for the page 'acq_acqui-home' and the table 'accounts'. 4. Hide each column and make sure it hides correctly on acqui-home.pl 5. Test the export options (Excel, CSV, etc) and make sure hidden columns do not show up. 6. Make sure the totals at the bottom of the screen can still be calculated Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual-updated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This doesn't work for me. I tried on a bywater sandbox, just in case it was my installation that was the problem, and it's not working. Test plan : 1) Go to Acquisitions --> Notice the 'All available funds' table doesn't have a 'Columns' button 2) Go to Administration > Table settings > Acquisitions and find the accounts table 3) Check 'Is hidden by default' on 'owner' and 'library' 4) Click 'Save' 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5) --> Notice the Owner and Library columns are still there -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #11)
This doesn't work for me.
I tried on a bywater sandbox, just in case it was my installation that was the problem, and it's not working.
Test plan : 1) Go to Acquisitions --> Notice the 'All available funds' table doesn't have a 'Columns' button 2) Go to Administration > Table settings > Acquisitions and find the accounts table 3) Check 'Is hidden by default' on 'owner' and 'library' 4) Click 'Save' 5) Go back to Acquisitions, refresh the page if needed (Ctrl+F5) --> Notice the Owner and Library columns are still there
Hi Caroline, I saw the interaction in IRC earlier, but rule of thumb is never to reopen a bug that has been pushed and released - could you file a new bug instad and link them? We also need this to have proper release notes later for the fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30938 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I opened bug 30938 and copy pasted my comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30938 [Bug 30938] Add column configuration to the acquisitions home page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for opening Bug 30938 Caroline. I am re-closing this one. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org