[Bug 43155] New: POS breaks on modal if change required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Bug ID: 43155 Summary: POS breaks on modal if change required Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Point of Sale Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: martin.renvoize@openfifth.co.uk Target Milestone: --- This only happens if the patron is owed change. If we enter in an exact amount tendered, everything works. We are seeing a bug with the POS. If I have an amount owed in the POS, like $1.25, and I enter $2.00 tendered, and press confirm, a modal comes up asking to confirm the change owed. If I press yes, nothing happens. If I run console.log("Koha:", Koha); console.log("Koha.prefs:", Koha?.prefs); directly in the browser console on that page, I get: Koha: { ... } Koha.prefs: undefined It looks like Koha.prefs is not being initialized. If I run this in the console on that page: Koha.prefs = Koha.prefs || {}; Koha.prefs.FinePaymentAutoPopup = false; Then I enter the amount tendered over the amount owed, the confirmation comes up, I press yes, and it works. I temporary workaround I've come up with seems to get us by for the moment: //TEMPORARY Workaround for POS bug - 7/22/26 $(function () { Koha = window.Koha || {}; Koha.prefs = Koha.prefs || {}; }); //TEMPORARY Workaround for POS bug - 7/22/26 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- ByWater says this is working in Main, so it got fixed at some point after 25.11.06, but I don't know what or when. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 202555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202555&action=edit Bug 43155: POS breaks on modal if change required This patch reverts a change made by bug 41705 that does not work in versions older than 26.05. Only needed for 25.11.x To test: Before applying the patch: 1. Turn on the following system preferences: EnablePointOfSale UseCashRegisters 2. In Administration, add a cash register for your library 3. In Administration, set a debit type to be Saleable 4. In Point of Sale, add your debit type as a sale, set it to 1.00 5. In the 'tendered' box, put 2.00 6. Select 'Cash' for type 7. Hit pay, then again in the popup 8. Observe nothing happens. 9. Apply the patch 10. Refresh the point of sale 11. Repeat steps 4-7 12. The popup should properly clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202555|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 202560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202560&action=edit Bug 43155: POS breaks on modal if change required This patch reverts a change made by bug 41705 that does not work in versions older than 26.05. Only needed for 25.11.x To test: Before applying the patch: 1. Turn on the following system preferences: EnablePointOfSale UseCashRegisters 2. In Administration, add a cash register for your library 3. In Administration, set a debit type to be Saleable 4. In Point of Sale, add your debit type as a sale, set it to 1.00 5. In the 'tendered' box, put 2.00 6. Select 'Cash' for type 7. Hit pay, then again in the popup 8. Observe nothing happens. 9. Apply the patch 10. Refresh the point of sale 11. Repeat steps 4-7 12. The popup should properly clear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Text to go in the| |This fixes an issue when release notes| |using the point of sale | |system where change is | |required for a transaction. | |Clicking "Yes" in the | |pop-up window to confirm | |did nothing, and the | |transaction could not be | |completed. --- Comment #4 from David Nind <david@davidnind.com> --- Changed to normal (from enhancement). Should it be higher? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Kathleen <kkosiec@santabarbaraca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkosiec@santabarbaraca.gov --- Comment #5 from Kathleen <kkosiec@santabarbaraca.gov> --- This bug is causing issues for us at SBPL. Looking forward to a fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@openfifth.c |paul.derscheid@lmscloud.de |o.uk | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41705 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41705 [Bug 41705] Popup blockers may be triggered by options to automatically display payment receipt for printing after making a payments -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|paul.derscheid@lmscloud.de |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 202966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202966&action=edit Bug 43155: POS breaks on modal if change required This patch reverts a change made by bug 41705 that does not work in versions older than 26.05. Only needed for 25.11.x To test: Before applying the patch: 1. Turn on the following system preferences: EnablePointOfSale UseCashRegisters 2. In Administration, add a cash register for your library 3. In Administration, set a debit type to be Saleable 4. In Point of Sale, add your debit type as a sale, set it to 1.00 5. In the 'tendered' box, put 2.00 6. Select 'Cash' for type 7. Hit pay, then again in the popup 8. Observe nothing happens. 9. Apply the patch 10. Refresh the point of sale 11. Repeat steps 4-7 12. The popup should properly clear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Mwoo <mary.woodward@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mary.woodward@bedfordtx.gov --- Comment #7 from Mwoo <mary.woodward@bedfordtx.gov> --- This is a big problem for our library. We are also getting this error for any transaction even if the transaction doesn't require change. Because staff doesn't think the transaction didn't go through they click the confirm button again and again and again. This creates a huge headache when trying to reconcile the next morning. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable Version(s)| |25.11.09 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.09 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43155 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org