[Bug 10743] New: add style to privacy rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Bug ID: 10743 Summary: add style to privacy rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: nengard@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org On the 'my privacy' page in the OPAC the privacy container includes the header, so I think we need another container for just the privacy rules so that it can be easily edited. Patch to follow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 20413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20413&action=edit Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20413|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20506&action=edit [SIGNED-OFF] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Edit: Replaced a few tabs with spaces to keep the QA script happy. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20506|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20521&action=edit [PASSED QA] Bug 10743: Add styles to 'my privacy' page in OPAC This patch does a couple things. Most importantly it adds a new div around the privacy rules summary so that it can be easily changed. It also moves the start of the form to right above the form's select box so that it's not in the new privacy rules div. To test: * Apply patch * Enable the use of privacy via the sys prefs * Log in to the OPAC * Visit the 'my privacy' tab * Make sure it looks okay * Submit the form and make sure it works * Repeat in the other theme Signed-off-by: Owen Leonard <oleonard@myacpl.org> Edit: Replaced a few tabs with spaces to keep the QA script happy. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, privacy options can still be edited. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Nicole! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org