[Bug 20823] New: UNIMARC XSLT does not display 604$t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Bug ID: 20823 Summary: UNIMARC XSLT does not display 604$t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In UNIMARC, 604 contains subfield t. Actual XSLT files use template tag_subject for 604, it does not use t subfield. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 75566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75566&action=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune@bulac.fr --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Works correctly for Intranet but on OPAC, only the label is displayed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Sorry Frido for the delay, I completely missed your comment ! (In reply to Fridolin SOMERS from comment #3)
I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. You're right, 604$t is correctly displayed when there is a 604$a, but the display depends of the order of creation of the fields ($t will be displayed first if created first, and vice verse for $a), is that normal ?
When I have several 604 subfields, the link is the same for all the 604 values, but the new search is only done on the first displayed value : shouldn’t we have a link for each subfield ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Séverine Queune from comment #4)
Sorry Frido for the delay, I completely missed your comment !
(In reply to Fridolin SOMERS from comment #3)
I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. You're right, 604$t is correctly displayed when there is a 604$a, but the display depends of the order of creation of the fields ($t will be displayed first if created first, and vice verse for $a), is that normal ?
I'd say yes.
When I have several 604 subfields, the link is the same for all the 604 values, but the new search is only done on the first displayed value : shouldn’t we have a link for each subfield ?
Oh, this patch only adds $t to the tag_subject template call. This is the behavior of tag_subject template, you may open a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #6 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Fridolin SOMERS from comment #5)
(In reply to Séverine Queune from comment #4)
Sorry Frido for the delay, I completely missed your comment !
(In reply to Fridolin SOMERS from comment #3)
I reproduce when 604 contains only $t. But I've seen UNIMARC 604 has $a mandatory. Please check with 604 $a and $t. You're right, 604$t is correctly displayed when there is a 604$a, but the display depends of the order of creation of the fields ($t will be displayed first if created first, and vice verse for $a), is that normal ?
I'd say yes.
Great ! Let's sign it then :)
When I have several 604 subfields, the link is the same for all the 604 values, but the new search is only done on the first displayed value : shouldn’t we have a link for each subfield ?
Oh, this patch only adds $t to the tag_subject template call. This is the behavior of tag_subject template, you may open a new bug. Ok, I'll do it.
Thanks Frido ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75566|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 --- Comment #8 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 85771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85771&action=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85771|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 86533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86533&action=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial patch that does what it says on the tin.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org