[Bug 15887] New: Revise layout and behavior of item search fields management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Bug ID: 15887 Summary: Revise layout and behavior of item search fields management Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/items_search_fields.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org The item search fields management page is unusual in that it show the list of existing custom search fields on the same page as an add form. I propose to add some JavaScript to show and hide the add form in order to simplify the interface and give each task better focus. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48319&action=edit Bug 15887 - Revise layout and behavior of item search fields management This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to <select>s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48319|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48335&action=edit [SIGNED-OFF]Bug 15887: Revise layout and behavior of item search fields management This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to <select>s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. JSHint OK, koha-qa OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com, | |nengard@gmail.com, | |nicole@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen Good Job. Looks much better. Just one comment, this page does not have help page. Add here Nicole. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Entering a new bug for the documentation issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- Documentation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15926 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> ---
- Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384).
Could you please revert this change? Before this patch, we had a validation on the MARC field values, now we don't. What happens if we enter 10 instead of 010, does it still work? I think we should add a validation on this form, but it's outside the scope of this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15384 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 [Bug 11425] Search form for items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
- Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384).
I think we should add a validation on this form, but it's outside the scope of this patch.
I think you're right that I'm pushing the limit on scope here, but I wonder if it isn't better for now to allow free entry on the form fields given the fact that in its current state there are some entries which cannot be made at all? Cait's comment on Bug 15384:
the subfield list is missing capital letters as often used for additional item fields.
If that doesn't sound like a good enough reason I'm happy to revise the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #7)
Cait's comment on Bug 15384:
the subfield list is missing capital letters as often used for additional item fields.
If that doesn't sound like a good enough reason I'm happy to revise the patch.
The main reason to move it to its own bug report is that the fix could be backported to stable branches. If it is embedded to this patch (enh), it won't be easy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48335|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48515&action=edit Bug 15887: Revise layout and behavior of item search fields management This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to <select>s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. JSHint OK, koha-qa OK. Revision per QA: Undid the change making tag and subfield inputs text fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry - I think I was to blame here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48515|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48539&action=edit Bug 15887: Revise layout and behavior of item search fields management This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to <select>s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. JSHint OK, koha-qa OK. Revision per QA: Undid the change making tag and subfield inputs text fields. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Mater - Should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15992 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org