[Bug 15517] New: deleted tables differ again
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Bug ID: 15517 Summary: deleted tables differ again Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The structure of borrowers and deletedborrowers differs again. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46403&action=edit Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46404&action=edit Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15478 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 [Bug 15478] Checksum mismatch when regenerating schema -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14067 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46403|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46457&action=edit [SIGNED-OFF]Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46404|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46458&action=edit [SIGNED-OFF]Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly. Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, thx for catching this! Something weird: After applying the patch and running the database update (I verified in MySQL Workbench that both tables match now) I still have the 2 tests failing for password and userid. It seems like it's not looking at the right db or has outdated information. Do you have an idea why this could happen? The other thing - shouldn't the test message not be: ok - ... don't differ ...? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... should read better... misc/devel/update_dbix_class_files.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|deleted tables differ again |Tables borrowers and | |deletedborrowers differ | |again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46457|0 |1 is obsolete| | Attachment #46458|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46466&action=edit [PASSED QA] Bug 15517: Resync borrowers and deletedborrowers tables The 2 columns password and userid are not sync and could cause errors when deleting patrons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 46467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46467&action=edit [PASSED QA] Bug 15517: deleted* tables won't never differ anymore! These tests will ensure that the 4 deleted* tables won't never differ anymore. Test plan: 0/ Do not execute the update DB entry 1/ prove t/db_dependent/db_structure.t should fail 2/ Execute the update DB entry and update the schema with misc/devel/update_dbix_class_files.pl 3/ prove t/db_dependent/db_structure.t should now be happy Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Test pass successfuly. Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46472&action=edit Bug 15517: Change wording for tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #5)
The other thing - shouldn't the test message not be:
ok - ... don't differ ...?
Yep! Fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15517 Bug 15517 depends on bug 15478, which changed state. Bug 15478 Summary: Checksum mismatch when regenerating schema http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15478 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org