[Bug 15332] New: ModMember not interpreting dates (Batch patron modification)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Bug ID: 15332 Summary: ModMember not interpreting dates (Batch patron modification) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org ModMember is not correctly interpreting dates if not passed in in ISO format. To see the issue: Go to Tools->Batch patron modification Enter some cardnumbers update any date field for the patrons Result is all null in that column The dates are being passed directly to ModMember without reformatting but there is an issue with DBIx::Class::ResultSet update where by dates are not processed/deflated http://search.cpan.org/dist/DBIx-Class/lib/DBIx/Class/ResultSet.pm#update I don't know whether the correct path here is to fix the call in Modmember, or to make modborrowers.pl pass the dates in a better format Marking as critical since data can be lost -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om --- Comment #1 from Danielle Elder <danielle@bywatersolutions.com> --- I was able to view this in action in batch patron modification where a library entered a new date expiry using the date picker and the date was set to 0000 - 00-00 Example: Before modification in tool: TEMP0041 | 2015-08-11 | TEMP0042 | 2015-11-15 | TEMP0043 | 2015-11-15 | After modification: TEMP0041 | 0000-00-00 | TEMP0042 | 0000-00-00 | TEMP0043 | 0000-00-00 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 --- Comment #2 from Danielle Elder <danielle@bywatersolutions.com> --- I was able to view this in action in batch patron modification where a library entered a new date expiry using the date picker and the date was set to 0000 - 00-00 Example with altered cardnumber: Before modification in tool: TEMP0041 | 2015-08-11 | TEMP0042 | 2015-11-15 | TEMP0043 | 2015-11-15 | After modification: TEMP0041 | 0000-00-00 | TEMP0042 | 0000-00-00 | TEMP0043 | 0000-00-00 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45839&action=edit Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates If formatted dates are sent to DBIx::Class on update/insert, the date will be set as 0000-00-00 (except if the format is yyyy-mm-dd). Test plan: Use the batch patron modification tools to update the dateenrolled or dateexpiry values for at least 1 patron. Without this patch, the modified value will be updated to 0000-00-00, with this patch, the correct value will be set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12633 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This has certainly been introduced by bug 12633 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 [Bug 12633] SQLHelper replacement - C4::Members -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have quickly checked the other calls and they look good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45839|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 45870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45870&action=edit Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates If formatted dates are sent to DBIx::Class on update/insert, the date will be set as 0000-00-00 (except if the format is yyyy-mm-dd). Test plan: Use the batch patron modification tools to update the dateenrolled or dateexpiry values for at least 1 patron. Without this patch, the modified value will be updated to 0000-00-00, with this patch, the correct value will be set. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45870|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 45980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45980&action=edit Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates If formatted dates are sent to DBIx::Class on update/insert, the date will be set as 0000-00-00 (except if the format is yyyy-mm-dd). Test plan: Use the batch patron modification tools to update the dateenrolled or dateexpiry values for at least 1 patron. Without this patch, the modified value will be updated to 0000-00-00, with this patch, the correct value will be set. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #8 from Marc Véron <veron@veron.ch> --- *** Bug 15425 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45980|0 |1 is obsolete| | --- Comment #9 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46057&action=edit Bug 15332: Sent DateTime object to DBIx::Class, not formatted dates If formatted dates are sent to DBIx::Class on update/insert, the date will be set as 0000-00-00 (except if the format is yyyy-mm-dd). Test plan: Use the batch patron modification tools to update the dateenrolled or dateexpiry values for at least 1 patron. Without this patch, the modified value will be updated to 0000-00-00, with this patch, the correct value will be set. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz, | |mtj@kohaaloha.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12309 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to Frédéric Demians from comment #12)
This patch has been pushed to 3.20.x, will be in 3.20.8.
FYI: This bug also exists in the 3.18.x series, introduced in BZ-12309 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15607 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15607 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15332 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15607 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15607 [Bug 15607] Batch patron modification: Data loss of 'dateenrolled' and 'expirydate' fields -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org