https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- This would ideally go one step further: If we are doing Koha::Patrons->find( $data{borrowernumber} ) there's no reason to do it again a couple of lines below: C4/Members.pm: my $rs = $schema->resultset('Borrower')->search({ borrowernumber => $new_borrower->{borrowernumber}, }); tools/modborrowers.pl: Two for my $borrowernumber ( @borrowernumbers ) {} loops should be merged -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53097|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55579&action=edit Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55579|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 56388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56388&action=edit Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56388|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 57057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57057&action=edit [PASSED QA] Bug 16852: Remove GetBorrowerCategorycode And use Koha::Patron->categorycode instead Test plan: - Restrict a patron attribute to a patron category - Use the batch patron modification tool to update a patron of this category You should not see the the patron attribute Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16852 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> --- enhancement, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes.