[Bug 28112] New: Z39.50 does not populate form with all passed criteria
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Bug ID: 28112 Summary: Z39.50 does not populate form with all passed criteria Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 1277 Bug 1277 added options to the Z39.50 search form but didn't take into account that search terms for those new fields might be passed in the URL. For example, a URL containing all possible fields: /cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear ...should bring up a form which has values in every field. Instead, these fields are empty: Subject heading Keyword (any) LC call number Control no. Dewey Standard ID Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1277 [Bug 1277] Enhance: Z39.50 More search criteria -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119309&action=edit Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119309|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 119316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119316&action=edit Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The "try another search" button will put you back on the prefilled form if you are using acqui/z3950_search. However cataloguing/z3950_search will display a blank form. Can be considered outside of the scope here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119316|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119567&action=edit Bug 28112: Z39.50 does not populate form with all passed criteria This patch adds output of some already-existing template variables in the Z39.50 search form so that all parameters can be used to prepopulate the form. To test, apply the patch and go to Cataloging. - Click the "New from Z39.50/SRU" button - A window should pop up and the form should be empty. - Confirm that searching works correctly. - Perform the same test from a bibliographic detail page using the Edit menu -> Replace record via Z39.50/SRU. - Some fields in the search form should be prepopulated, e.g. ISBN, title, author. - Paste this link into your browser: http://path.to.your.koha/cgi-bin/koha/cataloguing/z3950_search.pl?frameworkcode=&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear - The search form should appear with all fields prepopulated. - Perform the same tests in Acquisitions with the option for adding to a basket via an external search. - The link for testing all parameters: http://path.to.your.koha/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=4&basketno=3&isbn=isbn&issn=issn&title=title&author=author&dewey=dewey&subject=subject&lccall=lccall&controlnumber=controlnumber&stdid=stdid&srchany=srchany&publicationyear=publicationyear Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.05 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.05 |21.05.00,20.11.05,20.05.11 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28112 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org