[Bug 13400] New: Untranslatable "Are you sure you want to delete this authority?"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Bug ID: 13400 Summary: Untranslatable "Are you sure you want to delete this authority?" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Untranslatable javascript text: authorities/searchresultlist.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?'); authorities/detail.tt: var is_confirmed = confirm('Are you sure you want to delete this authority?'); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 34176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34176&action=edit Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron@veron.ch Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Marc did you test by updating and installing a translation? I'm not sure if I'm testing incorrectly, but it's not working for me. 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. perl translate -v install de-DE 5. Testing deleting an authority from the authority search results page I still got the default English confirmation message. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Never mind. I needed to add step 3a. Delete the "fuzzy" marker from the entry in the po file. Thanks to cait for pointing out my error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34176|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34278&action=edit [SIGNED-OFF] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34278|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34346&action=edit [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34346|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34347&action=edit [PASSED QA] Bug 13400 - Untranslatable "Are you sure you want to delete this authority?" This patch makes the string "Are you sure you want to delete this authority?" translatable using the function _(...) To test, apply patch and check that deleting authorities still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully with the following procedure: 1. Applied the patch. 2. Ran perl translate update de-DE 3. Edited de-DE-i-staff-t-prog-v-3006000.po to add a "translation" 4. Removed "#, fuzzy" marker from po entry. 5. perl translate -v install de-DE 6. Testing deleting an authority from the authority search results page and from the detail page. My translated string appeared correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34348&action=edit [PASSED QA] Bug 13400 [QA Followup] - Fix tabs and quotes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Holding for 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.16 CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Contains string changes, holding for 3.16.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 --- Comment #12 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org