[Bug 7924] New: koha-remove fails (in a different way) when dropping user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Priority: P5 - low Change sponsored?: --- Bug ID: 7924 Assignee: gmcharlt@gmail.com Summary: koha-remove fails (in a different way) when dropping user QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: Linux Reporter: koha-bugzilla@pkturner.org Hardware: PC Status: NEW Version: rel_3_6 Component: Installation and upgrade (command-line installer) Product: Koha Created attachment 9030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9030&action=edit koha-remove change I used as a workaround root:~# koha-remove library Removing Koha instance -- ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_--'@'%' root:~# The koha-remove shell script aborts upon this attempt. It has a list consisting of -- and 'library', and does not get so far as to attempt 'library'. I worked around this by saving the original value of "$@" because it appeared to me that "set -- $args" was corrupting the subsequent use of "$@". See attached patch. Debian squeeze, bash 4.1-3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Scott Turner <koha-bugzilla@pkturner.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha-bugzilla@pkturner.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |robin@catalyst.net.nz --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding Robin (package maintainer) in CC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Installation and upgrade |Packaging |(command-line installer) | Assignee|gmcharlt@gmail.com |robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- That's strange that the set would corrupt that. Off the top of my head, I'm not sure what would be going on there. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no Summary|koha-remove fails (in a |Fix handling of command |different way) when |line arguments in |dropping user |koha-remove -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|robin@catalyst.net.nz |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 9366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9366&action=edit Bug 7924 - Fix handling of command line arguments in koha-remove koha-remove would fail with a message like this: Removing Koha instance -- ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_--'@'%' After fixing this, the --keep-mysql option made the script exit without doing anything. To test: Alt 1 - Build package with build-git-snapshot - Install package Alt 2 - Replicate the changes in the patch in an existing installation Then: - Add instance1 and instance2 - koha-remove instance1 -- Check that script completes and the databse is gone - koha-remove --keep-mysql instance2 -- Check that the script completes but the database is not removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9030|0 |1 is obsolete| | Attachment #9366|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9456&action=edit Bug 7924 - Fix handling of command line arguments in koha-remove koha-remove would fail with a message like this: Removing Koha instance -- ERROR 1396 (HY000) at line 1: Operation DROP USER failed for 'koha_--'@'%' After fixing this, the --keep-mysql option made the script exit without doing anything. To test: Alt 1 - Build package with build-git-snapshot - Install package Alt 2 - Replicate the changes in the patch in an existing installation Then: - Add instance1 and instance2 - koha-remove instance1 -- Check that script completes and the databse is gone - koha-remove --keep-mysql instance2 -- Check that the script completes but the database is not removed Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. Incorporated into stable prior to inclusion in master because the patch is required for the release process. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Severity|major |critical --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Can we get this through qa please it is needed for the 3.8.1 releaae -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Only affects packages, and the changes look simple enough: add an eval, then move the exit line separate from the mysql command. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6684 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7924 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- This fix will be in 3.8.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org