[Bug 9168] New: Software error when filtering in receipt summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Bug ID: 9168 Summary: Software error when filtering in receipt summary Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolyn.somers@biblibre.com In acquisition, on receipt summary page : acqui/parcel.pl?inreceipt summaryvoiceid=X When using left filters (ISBN, basket, ...), you get a software error : Can't use an undefined value as an ARRAY reference at /home/koha/src/acqui/parcel.pl line 160. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13773&action=edit Proposed patch Hidden inputs of form where wrong. booksellerid and invoicedatereceived are not necessary, parcel.pl will find them using invoiceid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13774&action=edit Proposed patch (follow-up 1) Small follow-up: in parcel.pl booksellerid is set to template twice. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13773|0 |1 is obsolete| | Attachment #13774|0 |1 is obsolete| | --- Comment #3 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13793&action=edit [Signed off] Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #4 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13794&action=edit [Signed off] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com Patch complexity|--- |Small patch --- Comment #5 from Melia Meggs <melia@bywatersolutions.com> --- I tested this on master by using the filter on the left side of the receipt summary to search by author and got the software error that Fridolyn described. After applying the patches, I am able to search by author, title, basket and order line without getting any software error, so I am signing off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13793|0 |1 is obsolete| | Attachment #13794|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13809&action=edit [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13809|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13810&action=edit Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13811&action=edit [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13810|0 |1 is obsolete| | Attachment #13811|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13812&action=edit [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13813&action=edit [SIGNED-OFF] Bug 9168: Software error when filtering in receipt summary (followup) Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test: - Use filters on the 'order receive' page (don't confuse with invoices - filters are similar) - Verify that without patch filters are not functional - Verify that with patch applied filters work correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9168 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|master |3.10 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x, will be in 3.10.1 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org