[Bug 26425] New: Fix history.txt once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Bug ID: 26425 Summary: Fix history.txt once and for all Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 21662 On bug 21662, there was a commit "Use commitdates over RM dates" stated: """ The manual maintanence of the history.txt file lead to some discrepancies in first commit dates for many contributors. After a discussion regarding the automation proccess (and with some of the contributors who would be most heavily affected) we decided to update the history file on mass to match the commite dates found in the repository." """ But we don't have all the epoch matching the commit dates. Also, the version must be \d{1,2}.\d{2}\.\d{2}: minor and release must be displayed on 2 chars Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662 [Bug 21662] Missing developers from history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109853&action=edit Bug 26425: Add 2 chars for version This is a patch to catch with the correct format, and make the get_developers release-tools script works correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109854&action=edit Bug 26425: Update history.txt With the modifications brought by https://gitlab.com/koha-community/release-tools/-/issues/18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109853|0 |1 is obsolete| | Attachment #109854|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109887&action=edit Bug 26425: Manual changes Patches will be squashed when pushed. Here the changes are done manually, we add the missing 0 for the releases after 3.00.00 (with alpha, beta, etc) And we remove all the laters, that will added automatically by the release script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 109888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109888&action=edit Bug 26425: Update history.txt With the modifications brought by https://gitlab.com/koha-community/release-tools/-/issues/18 After the manual changes we can run the script with the 3 commits from the issue #18 of release-tools. * Add missing whitespace to align the dates * Add all the releases (from the tag list) after 3.00.00 There is no change in the developers numbering, neither in the wording. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109887|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110894&action=edit Bug 26425: Manual changes Patches will be squashed when pushed. Here the changes are done manually, we add the missing 0 for the releases after 3.00.00 (with alpha, beta, etc) And we remove all the laters, that will added automatically by the release script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109888|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110895&action=edit Bug 26425: Update history.txt With the modifications brought by https://gitlab.com/koha-community/release-tools/-/issues/18 After the manual changes we can run the script with the 3 commits from the issue #18 of release-tools. * Add missing whitespace to align the dates * Add all the releases (from the tag list) after 3.00.00 There is no change in the developers numbering, neither in the wording. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Discussed and agreed on IRC.. I'm happy with these patches moving us to a more consistent state :) Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As basically a string patch, and having dug deeply into the history of the project myself a few times on route to this point.. I think we can safely call it a PQA too :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 25442 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25700 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 [Bug 25700] Recent Kohacons are missing from the timeline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26425 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |About |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org