[Bug 20089] New: Does Koha::Database->schema always return a connected object?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20089 Bug ID: 20089 Summary: Does Koha::Database->schema always return a connected object? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org My log says no: DBD::mysql::st execute failed: MySQL server has gone away [for Statement "SELECT `me`.`variable`, `me`.`value`, `me`.`options`, `me`.`explanation`, `me`.`type` FROM `systempreferences` `me` WHERE ( `me`.`variable` = ? )" with ParamValues: 0='opacgroupresults'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. I see them quite often, always for preferences. Note that we do not test the cached $database->{schema} in sub schema. If we do, we will however add some time. ( 0.0043 instead of 0.0003 ) What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20089 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- For the record: - return $database->{schema} if defined $database->{schema}; + my $schema = $database->{schema}; + if( $schema && $schema->storage->connected ) { + return $schema; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org