[Bug 21943] New: Clean up holds template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Bug ID: 21943 Summary: Clean up holds template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 14546 There are some minor markup issues with the holds template in the staff client, including needing a Bootstrap grid upgrade. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82847&action=edit Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86305&action=edit Screenshot of responsive view Hi, Sorry the responsive view doesn't look quite right. Have a look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86454&action=edit Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82847|0 |1 is obsolete| | Attachment #86454|0 |1 is obsolete| | --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87533&action=edit Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87534&action=edit Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87533|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87554&action=edit Bug 21943: Clean up holds template This patch makes a few markup corrections to the holds template in the staff client: Replace some YUI markup with Bootstrap; Replace invalid "alt" attributes with "title." To test, apply the patch and test the process of placing a hold, both single and multiple holds. At each step of the process the page should look correct and adjust well at various browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87534|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87555&action=edit Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org