[Bug 6770] New: AllowHoldPolicyOverride not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Bug #: 6770 Summary: AllowHoldPolicyOverride not working Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Hold requests AssignedTo: ian.walls@bywatersolutions.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com When a patron has more than 5 holds staff was previously able to place holds for the patron over-riding the 5 hold limit (with the AllowHoldPolicyOverride pref set to allow). I find that I am unable to do that at this time. I know I was previously able to over-ride the 5 hold limit for patrons. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ian.walls@bywatersolutions. |srdjan@catalyst.net.nz |com | --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-09-06 04:14:41 UTC --- Created attachment 5313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5313 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5313|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-09-08 00:06:35 UTC --- Created attachment 5347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5347 [SIGNED-OFF] bug_6770: removed doubled override increment when using AllowHoldPolicyOverride Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 16:53:42 UTC --- Removes duplicate logic, and overall simplifies a very complex and unpleasant conditional. In my testing, this works in a variety of "cannot place hold" situations. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-06 20:38:35 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-08 21:52:55 UTC --- This does not apply cleanly to 3.4.x. If it should, please rebase against the 3.4.x branch and resubmit with [3.4.x] in the subject line. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5347|0 |1 is obsolete| | --- Comment #6 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-10 01:05:45 UTC --- Created attachment 5819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5819 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Patch Pushed |Needs Signoff --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-10 01:06:47 UTC --- Sorry, I missed to put [3.4.x] in the subject line -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-10-11 13:40:50 UTC --- This doesn't need a second signoff does it? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_4 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-19 19:08:16 UTC --- Owen, right, this has just been updated for 3.4.x. Chris N, this should apply now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-26 15:55:19 UTC --- fixed in 3.6 Chris_n, can you take care of it in 3.4 ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 --- Comment #11 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 16:44:54 UTC --- (In reply to comment #10)
fixed in 3.6 Chris_n, can you take care of it in 3.4 ?
Done already. tnx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6770 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-10-26 16:45:59 UTC --- Marking patch pushed since this was bumped back to 3.4.x. Please test and close. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org