[Bug 13680] New: Items list on edit items page separates add items form from header and sidebar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Bug ID: 13680 Summary: Items list on edit items page separates add items form from header and sidebar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nick@quecheelibrary.org QA Contact: testopia@bugs.koha-community.org Created attachment 35720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35720&action=edit Proposed layout On records with multiple items attached the add items form can be pushed down the page, separating it from the header and sidebar and requiring a choice between where pages focus should fall and often leading to scrolling depending on your action. See bug 11905 A different solution would be to move the existing items list to the bottom of the page. This is a fairly striking difference, but with the addition of edit item links on the record detail page I don't think it makes selecting an item to edit more onerous. That being said, change is upsetting and I believe this would need some discussion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #1 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 35721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35721&action=edit Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org Assignee|oleonard@myacpl.org |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35721|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36128&action=edit Bug 13680 - Items list on edit items page separates add items form from header and sidebar This patch moves the items table on the edit items screen to the bottom of the page. Test plan: 1 - Apply patch 2 - Ensure adding/editing items works as previously Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> I like this idea a lot. I think if everyone gave it a shot and got used to the work flow then everyone would love it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 36128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36128 Bug 13680 - Items list on edit items page separates add items form from header and sidebar Review of attachment 36128: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13680&attachment=36128) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +134,4 @@
<div id="bd"> <div id="yui-main"> +<h1>Add items to [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1>
Not sure this change is consistent: If you edit an item, you see: Add items to my_bib Edit Item #23192 There is Add vs Edit on the same page. Maybe it is better to keep the original wording here, don't you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #4 from Nick Clemens <nick@quecheelibrary.org> --- Yeah, see your point, my only thought was it might seem odd to say "Items for TITLE_OF_BIB" when the items are not listed immediately. 'why I added the "Existing items for TITLE_OF_BIB" above the item list I am happy to keeping the wording as is, but maybe would prefer either: 1 - "Edit items for TITLE_OF_BIB" 2 - "TITLE_OF_BIB" and let the "Add item/Edit item #" indicate the current action -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure yet if I am just 'ew change!' or if it's something else that bothers me. Still turning this around in my head, not feeling quite ready to pass QA. I'd like to get some more eyes on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #6 from Marc Véron <veron@veron.ch> --- I played around with the orignil an d the new version. My conclusion is that the new version (item list on bottom of the page) would be better. CSS patch follows as a proposition for formatting the form a little bit to make it more compact and better readable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 36425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36425&action=edit Bug 13680 - Make form on edit items page more compact and better readable This patch makes the form on the edit items page more compact by decreasing the label font and indenting properly if a laberl has multiple rows. Additionally, a thin white line helps the eye to connect a label with the appropriate field. It is just a proposition regardless whether the form will be displayed above or below the items table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- I know it is a little late in the game, but just to stir up the pot a bit, what if the list was collapsed during edit? Show only the record being edited, and all other items are in an expandable list? The list would be expanded when not editing, and contracts during edit. The plus to this is you get to see the line, and there is less scrolling. Frankly, I don't think the edit screen should always be open. I think it leads to confusion as to whether you've got something new or editing something from the list. I would go as far as collapsing the edit list when not in use, or making it modal. Just my added two cents. Thoughts? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christopher, I had similar thoughts at this +1 for your suggestions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14409 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13680 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #8)
I know it is a little late in the game, but just to stir up the pot a bit, what if the list was collapsed during edit? Show only the record being edited, and all other items are in an expandable list? The list would be expanded when not editing, and contracts during edit.
The plus to this is you get to see the line, and there is less scrolling.
Frankly, I don't think the edit screen should always be open. I think it leads to confusion as to whether you've got something new or editing something from the list. I would go as far as collapsing the edit list when not in use, or making it modal. Just my added two cents.
Thoughts?
+1 for modal! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org