[Bug 30911] New: Datatables error on course-details.pl after adding a bib-level course reserve
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Bug ID: 30911 Summary: Datatables error on course-details.pl after adding a bib-level course reserve Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to course resereves, add a course. 2. Go to the course and add a reserve at the bib-level ( use biblionumber of a bibliographic record ) 3. Notice the normal DataTable controls are missing and if you look at the browser console you will see an error: Uncaught TypeError: i is undefined -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- This is due to the way DataTables supports colspans. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 [Bug 14237] Allow bibs to be added to course without items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 137413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137413&action=edit Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137413|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137426&action=edit Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks a lot, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137426|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137427&action=edit Bug 30911: Datatables error on course-details.pl after adding a bib-level course reserve This patch removes the colspan from biblio-level course reserves rows in favor of adding a style to the message's container allowing it to overflow across table cells. To test, apply the patch and go to course reserves. 1. If necessary, add a new course. 2. View the details of the course and add a reserve using the biblionumber option to add the reserve at the bibliographic level. 3. Add a notes if you want, then click "Save." 4. Return to the course detail view. 5. In the table of reserves your biblio-level reserve should have a message starting in the "Barcode" column and overflowing across other item information columns, "Item information is not available for record-level course reserve." 6. Try adding multiple item-level and biblio-level reserves to the same course to confirm that the information displays well in those cases. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30911 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #10)
Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed.
Nothing to document, marking resolved.
Dependency is not in 21.11. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org