[Bug 28750] New: Undefined subroutines in svc/cataloguing/framework (caused by bug 17600)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Bug ID: 28750 Summary: Undefined subroutines in svc/cataloguing/framework (caused by bug 17600) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123118&action=edit Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think there are all the svc scripts that need to be double checked. I can do it on Monday if nobody beats me to it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123121&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123121|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123124&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123144&action=edit Bug 28750: fix svc/bib_framework -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123118|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 123154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123154&action=edit Bug 28750: (bug 17600 follow-up) Use full path for subroutines Throughout the file we call methods with the module Following suit rather than importing the methods To test: 1 - Attempt to load advanced cataloging editor 2 - it fails 3 - http://localhost:8081/cgi-bin/koha/svc/cataloguing/framework?frameworkcode=&callback=define 4 - Undefined subroutine &CGI::Compile::ROOT::kohadevbox_koha_svc_cataloguing_framework::GetMarcStructure called at /kohadevbox/koha/svc/cataloguing/framework line 18 5 - Apply patch 6 - Cataloging editor loads! 7 - Link in #3 loads! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123124|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 123155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123155&action=edit Bug 28750: (bug 17600 follow-up) Use full routine names in svc/new_bib svc/bib To test: 1 - Attempt to save a record in the advanced cataloging editor 2 - It fails 3 - Apply patch 4 - It succeeds Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123144|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 123156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123156&action=edit Bug 28750: fix svc/bib_framework Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #9 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker) - Before applying patches: . can edit and save a record using the default editor (for example, edit title for a book - where BKS framework used) . can't edit using advanced editor: sits on screen with icon going around "Loading..." . result from accessing URL in step 3 is error in step 4 of test plan - After applying patches: . advanced editor loads! . any edits using the normal or advanced editor complain about missing 003 field (didn't before the patch, even though was mandatory before and doesn't display by default) . page with framework data loads for URL in step 3 . can edit and save records using the advanced editor (and normal editor) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 [Bug 17600] Standardize the EXPORT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |CLOSED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes and issue in release notes| |master caused by bug 17600. | |This resulted in the | |advanced cataloguing editor | |failing to load. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes and issue in |This fixes an issue in release notes|master caused by bug 17600. |master caused by bug 17600. |This resulted in the |This resulted in the |advanced cataloguing editor |advanced cataloguing editor |failing to load. |failing to load. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Bug 28750 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28750 Bug 28750 depends on bug 17600, which changed state. Bug 17600 Summary: Standardize the EXPORT https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17600 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org