[Bug 14485] New: HTML comment disables translation in cataloguing/addbooks.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Bug ID: 14485 Summary: HTML comment disables translation in cataloguing/addbooks.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 40754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40754&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment. Test plan : - without patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Maybe there are other places where HTML comment should be converted. In my opinion, HTML comments should not be used since we can use TT comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Fridolin, I am not sure it's right fix. In the po files, I get: msgid "%s %s No results found %s %s %s %s result(s) found in catalog, " Which is not easily translatable. I'd suggest to put span around the strings in order to have something like: msgid "%s result(s) found in catalog," and msgid "No results found" By the way this second string is already translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3) Yep, that was one of my ideas. I propose a even a div. We should fix the fact that TT comments should not be translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40754|0 |1 is obsolete| | --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 40782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40782&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40782|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 40789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40789&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40789|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40858&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into <sources>/misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable Component|translate.koha-community.or |I18N/L10N |g | QA Contact|testopia@bugs.koha-communit | |y.org | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org