[Bug 24646] New: RoundFinesAtPayment is not a self check in preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Bug ID: 24646 Summary: RoundFinesAtPayment is not a self check in preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Ended up in wrong section, assuming just a rebase confusion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98771&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98771|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 99064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99064&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, it looks like this patch needs a clean-up (check the diff, you will see) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99064|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99234&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under 'Fines Policy' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this 'just fines' or payments in general? If it's payments in general perhaps it should live under the new 'Accounting' tab instead, under the 'Policy' section? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99234|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99293&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99293|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 99459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99459&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99459|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99464&action=edit Bug 24646: Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #11 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24646 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 100685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100685&action=edit Bug 24646: [19.11.x] Move RoundFinesAtPayment to 'Fines policy' section To test: - Search Admin->System preferences for 'RoundFinesAtPayment' - Note it is listed under self-check - Apply patch - Restart/refresh - Note it is now under Accounting -> Policy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org