[Bug 11117] New: Right to left text in facets + facet count = mixed text
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bug ID: 11117 Summary: Right to left text in facets + facet count = mixed text Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 22294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22294&action=edit Right-to-left parenthesis mixup Steps to reproduce: - Have facets to show some right to left text (for example ص) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 27552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27552&action=edit Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27552|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27553&action=edit [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. Also checked with Arabic translation, OPAC bootstrap, prog and ccsr. Tested with arabic records. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 27554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27554&action=edit Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27554|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27722&action=edit [SIGNED-OFF] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Still work as described. Checked in arabic with arabic records. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27722|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27752&action=edit [PASSED QA] Bug 11117: Fix text mixed in facets where RTL text + facet count showed This patch adds classes for both the facet label and count, and adds 'inline-block' to the 'facet-count' class so text shows proplerly. To reproduce: - Have facets to show some right to left text (example on the bug report) in english language templates. - Enable the displayFacetCount. - Check it displays like the attached snapshot. To test: - Apply the patch - Do a search that previously reproduced the problem on the staff interface => Shows correctly - Repeat for OPAC (the three themes) => Shows correctly - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Still work as described. Checked in arabic with arabic records. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Confirmed bug and that the patch fixes it, tested in staff, prog, ccsr and bootstrap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org