[Bug 21877] New: Show authorized value description for withdrawn in checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Bug ID: 21877 Summary: Show authorized value description for withdrawn in checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20341 [Bug 20341] Show authorized value description for withdrawn like damaged and lost -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15922 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 82616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82616&action=edit Bug 21877: Show authorized value description for withdrawn in checkout During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. This patch adds this display. Add <span> so that translation does not change. Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Edit an item with withdrawn=1 5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)' 6) Edit an item with withdrawn=2 7) Checkout this item => You see 'Item has been withdrawn' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82616|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82624&action=edit Bug 21877: Show authorized value description for withdrawn in checkout During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. This patch adds this display. Add <span> so that translation does not change. Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Edit an item with withdrawn=1 5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)' 6) Edit an item with withdrawn=2 7) Checkout this item => You see 'Item has been withdrawn' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21883 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why are not you doing it the same way as notforloan? Or provide tests, but I'd prefer consistency... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
Why are not you doing it the same way as notforloan?
Or provide tests, but I'd prefer consistency...
In Circulation.pm its the same : $needsconfirmation{item_notforloan} = $item->{'notforloan'}; $issuingimpossible{item_withdrawn} = $item->{'withdrawn'}; In circulation.tt : notforloan uses AuthorisedValues.GetByCode( authvalcode_notforloan ... authvalcode_notforloan is computed in circulation.pl this useful because it is used several times in circulation.tt. But for withdrawn the authorised value is used only once. Using AuthorisedValues.GetDescriptionByKohaField is better for MVC separation no ? I could create another bug to change notforloan maybe ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 83400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83400&action=edit Bug 21877: [ALTERNATIVE-PATCH] Display authorized value description for withdrawn in checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
Created attachment 83400 [details] [review] Bug 21877: [ALTERNATIVE-PATCH] Display authorized value description for withdrawn in checkout
Hi Frido, This is what I had in mind. It will avoid adding more stuff to C4::Circulation as well as unify the way we display/fetch the values I would prefer this approach and provide selenium tests. Note that another occurrence of notforloan must be replaced in circulation.tt What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22021 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #5)
Created attachment 83400 [details] [review] [review] Bug 21877: [ALTERNATIVE-PATCH] Display authorized value description for withdrawn in checkout
Hi Frido, This is what I had in mind. It will avoid adding more stuff to C4::Circulation as well as unify the way we display/fetch the values
I would prefer this approach and provide selenium tests.
Note that another occurrence of notforloan must be replaced in circulation.tt
What do you think?
OK better indeed. I will signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83400|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Ah in the end I review all the code and split into 2 patches : - adding withdrawn description - changing the way notforloan description is fetched -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84273&action=edit Bug 21877: Show authorized value description for withdrawn in checkout During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. This patch adds this display. Add <span> so that translation does not change. Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Edit an item with withdrawn=1 5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)' 6) Edit an item with withdrawn=2 7) Checkout this item => You see 'Item has been withdrawn' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84274&action=edit Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in checkout Using only TT plugin for authorised value description is a better code. Test plan : Part 1: 1.1) On a catalog with items.notforloan defined with authorized values category NOT_LOAN 1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach' 1.3) Define in NOT_LOAN an authorized values 2 with description empty Part 2: 2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow' 2.2) Edit an item with notforloan=1 2.3) Checkout this item => You see 'Item not for loan (at the beach)' 2.4) Edit an item with notforloan=2 2.5) Checkout this item => You see 'Item not for loan' Part 3: 3.1) Set preference 'AllowNotForLoanOverride' to 'Allow' 3.2) Edit an item with notforloan=1 3.3) Checkout this item => You see 'Item is normally not for loan (at the beach)' 3.4) Edit an item with notforloan=2 3.5) Checkout this item => You see 'Item is normally not for loan' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #11 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Both patches seems to be fine and I will probably sign them off. When I do a test with NOT_LOAN and AV = 2, I see this : "Item not for loan .". There is a space character created by the dot no matter what the system preference setting is. I wonder if it can be fixed as well too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84273|0 |1 is obsolete| | --- Comment #12 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 84436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84436&action=edit Bug 21877: Show authorized value description for withdrawn in checkout During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. This patch adds this display. Add <span> so that translation does not change. Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Edit an item with withdrawn=1 5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)' 6) Edit an item with withdrawn=2 7) Checkout this item => You see 'Item has been withdrawn' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84274|0 |1 is obsolete| | --- Comment #13 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 84437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84437&action=edit Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in checkout Using only TT plugin for authorised value description is a better code. Test plan : Part 1: 1.1) On a catalog with items.notforloan defined with authorized values category NOT_LOAN 1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach' 1.3) Define in NOT_LOAN an authorized values 2 with description empty Part 2: 2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow' 2.2) Edit an item with notforloan=1 2.3) Checkout this item => You see 'Item not for loan (at the beach)' 2.4) Edit an item with notforloan=2 2.5) Checkout this item => You see 'Item not for loan' Part 3: 3.1) Set preference 'AllowNotForLoanOverride' to 'Allow' 3.2) Edit an item with notforloan=1 3.3) Checkout this item => You see 'Item is normally not for loan (at the beach)' 3.4) Edit an item with notforloan=2 3.5) Checkout this item => You see 'Item is normally not for loan' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84436|0 |1 is obsolete| | Attachment #84437|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84448&action=edit Bug 21877: Show authorized value description for withdrawn in checkout During checkout the withdrawn information is displayed in a message : "Item has been withdrawn". Like in other pages and like notforloan, we should display the withdrawn authorized value description. This patch adds this display. Add <span> so that translation does not change. Also adds class 'co-withdrawn' (like in checkin 'ci-*' classes) to ease hidding this new information via CSS. Test plan : 1) On a catalog with items.withdrawn defined with authorized values category WITHDRAWN 2) Define in WITHDRAWN an authorized values 1 with description 'dropped in trash' 3) Define in WITHDRAWN an authorized values 2 with description empty 4) Edit an item with withdrawn=1 5) Checkout this item => You see 'Item has been withdrawn (dropped in trash)' 6) Edit an item with withdrawn=2 7) Checkout this item => You see 'Item has been withdrawn' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84449&action=edit Bug 21877: Use AuthorisedValues.GetDescriptionByKohaField for notforloan in checkout Using only TT plugin for authorised value description is a better code. Test plan : Part 1: 1.1) On a catalog with items.notforloan defined with authorized values category NOT_LOAN 1.2) Define in NOT_LOAN an authorized values 1 with description 'at the beach' 1.3) Define in NOT_LOAN an authorized values 2 with description empty Part 2: 2.1) Set preference 'AllowNotForLoanOverride' to 'Don't allow' 2.2) Edit an item with notforloan=1 2.3) Checkout this item => You see 'Item not for loan (at the beach)' 2.4) Edit an item with notforloan=2 2.5) Checkout this item => You see 'Item not for loan' Part 3: 3.1) Set preference 'AllowNotForLoanOverride' to 'Allow' 3.2) Edit an item with notforloan=1 3.3) Checkout this item => You see 'Item is normally not for loan (at the beach)' 3.4) Edit an item with notforloan=2 3.5) Checkout this item => You see 'Item is normally not for loan' Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #19 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 --- Comment #20 from Salman Ali <salman.ali@inLibro.com> --- Created attachment 121747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121747&action=edit Bug 28177: Add date column and column configuration to uploads This patch adds a "Date added" column to the table showing uploaded files. Column configuration is added to the table, and the date column is hidden by default. To test, apply the patch and restart all. - Go to Tools -> Upload. - If necessary, upload multiple files with the same category. - Use the "Search uploads by category" form to find those uploads. - In the table of uploads, confirm that table settings and other DataTable controls work correctly, including the option to show the "Date added" column. - Go to Administration -> Table settings -> Tools -> upload. - Change the settings for the uploads table. - Return to Uploads and confirm that your changes are reflected in the display of the uploads table. Signed-off-by: Salman Ali <salman@outaouais> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21877 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org