[Bug 19343] New: Private lists displayed in search results list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Bug ID: 19343 Summary: Private lists displayed in search results list Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: sanja.cancar@freshfields.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 67215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67215&action=edit Private list appears in the search results list Hi all, it seems that there is a bug when searching for titles on the opac. On the search results lists you receive the information about lists that are set on private - the lists are from other users. Attached you will see a search results list that should not contain the information about this list. The list is from another user and set on private. Also the information is not displayed when you open the bibliographic record. And when trying to click on it, you receive this statement "You do not have permission to view this list.". It seems that the only difference to other lists is that the permissions are set to "allow anyone else to add entries". When I change this setting, the list is not displayed in the search results anymore. Although from my point of view the “private” setting should overrule the other settings, this isn't currently possible and would require some development work. Kind regards, Sanja -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67550&action=edit Bug 19343: [16.11.X] Remove private lists with edit permission from search results If the list is not shared, it should not be listed. We only need to remove the allow_add line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67552&action=edit Bug 19343: [17.05.X] Remove private lists with edit permission from search results If the list is not shared, it should not be listed. We only need to remove the allow_add line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to SaCa from comment #0)
it seems that there is a bug when searching for titles on the opac.
On the search results lists you receive the information about lists that are set on private - the lists are from other users. Attached you will see a search results list that should not contain the information about this list. The list is from another user and set on private. Also the information is not displayed when you open the bibliographic record. And when trying to click on it, you receive this statement "You do not have permission to view this list.".
It seems that the only difference to other lists is that the permissions are set to "allow anyone else to add entries". When I change this setting, the list is not displayed in the search results anymore.
Although from my point of view the “private” setting should overrule the other settings, this isn't currently possible and would require some development work.
Good observation, Sanja. This bug has been solved in master (17.11) by bug 18228. It is present in 16.11 and 17.05 (not in 16.05). Are you in the position to test the attached patch? It should resolve your problem under 16.11. If not, you will have to wait until it gets attention from the release maintainer(s). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18228 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |17.05 Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Fridolin and Katrin: This resolves a bug that is only on 17.05/16.11. It is a rather trivial oneliner. Can you test it yourself or does it need further outside attention? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |16551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16551 [Bug 16551] Display the name of lists to the search results at the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67559&action=edit Bug 19343: Add tests - do not display a list when private -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67560&action=edit Bug 19343: [17.05.X] Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67561&action=edit Bug 19343: [16.11.X] Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Signed off on all patches (lazy to re-upload them with the signed-off-by line) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - allow_add => 1, + allow_change_from_owner => 1, + allow_change_from_others => 1, THis change in master does not apply. And I wonder if it makes sense too, since not adding these lines does not make a difference. Test still passes. Please adjust. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67559|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #10)
- allow_add => 1, + allow_change_from_owner => 1, + allow_change_from_others => 1,
THis change in master does not apply. And I wonder if it makes sense too, since not adding these lines does not make a difference. Test still passes. Please adjust.
Yes right, this patch is not needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)
(In reply to Marcel de Rooy from comment #10)
- allow_add => 1, + allow_change_from_owner => 1, + allow_change_from_others => 1,
THis change in master does not apply. And I wonder if it makes sense too, since not adding these lines does not make a difference. Test still passes. Please adjust.
Yes right, this patch is not needed.
Obsoleting the other two patches too for the same reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
Signed off on all patches (lazy to re-upload them with the signed-off-by line)
Will add your signoff line and update status now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67550|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67630&action=edit Bug 19343: [16.11.X] Remove private lists with edit permission from search results If the list is not shared, it should not be listed. We only need to remove the allow_add line. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67552|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67631&action=edit Bug 19343: [17.05.X] Remove private lists with edit permission from search results If the list is not shared, it should not be listed. We only need to remove the allow_add line. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |17.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Fridolin: It is your turn now. The patch is not needed in master, but it is in 17.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67560|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67561|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #12)
Obsoleting the other two patches too for the same reason.
I unobsoleted them because the change in the tests makes sense to me, it fails without the fix. # Failed test 'Only shelf1 should be displayed for patron 1 and biblio 1' # at t/db_dependent/Virtualshelves.t line 481. # got: '2' # expected: '1' # Looks like you failed 1 test of 9. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19343 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.18 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org