[Bug 24690] New: Make OPACPopupAuthorsSearch work with search terms containing parenthesis
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug ID: 24690 Summary: Make OPACPopupAuthorsSearch work with search terms containing parenthesis Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org As noted in bug 13327 this feature doesn't work when the selected search terms contain (). No results will be found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug 24690 depends on bug 13327, which changed state. Bug 13327 Summary: OPACPopupAuthorsSearch doesn't work with XSLT views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168315&action=edit Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168316&action=edit MARC file containing records for testing This file will give you records containing the author "Criterion Collection (firm)" (not an authority record link) with which to test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168315|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 168334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168334&action=edit Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorsSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorisSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorsSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the OPAC so that release notes| |when OPACPopupAuthorsSearch | |is enabled, author names | |not linked to an authority | |record that have | |parenthesis (for example, | |Criterion Collection | |(Firm)) correctly return | |results. Previously, author | |names with parenthesis did | |not return search results. --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. I amended the patch commit message - OPACPopupAuthorSearch ==> OPACPopupAuthorsSearch (added s for Authors). 2. Thanks for providing the sample records! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168334|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 174549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174549&action=edit Bug 24690: Make OPACPopupAuthorsSearch work with search terms containing parenthesis This patch updates the OPACPopupAuthorsSearch feature so that it wraps search terms with quotes. This is the behavior we have in place for author searches outside the context of OPACPopupAuthorisSearch, e.g. 'au:"Criterion Collection (Firm)"' To test, apply the patch and enable the OPACPopupAuthorsSearch system preference. - Search for a record in the OPAC which has author data containing parentheses (it should not be a field linked to an authority record). - View the detail page for that record. - Click on one of the problematic author links. - This should trigger a modal window with a list of authors and checkboxes for each. - With just the single checkbox checked, click "Search." - The search should return the correct results. - Test other author searches to confirm that they work too. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED CC| |jesse@bywatersolutions.com Resolution|--- |FIXED --- Comment #9 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org