[Bug 19444] New: Automatic renewal script should not auto-renew if a patron' s record has expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Bug ID: 19444 Summary: Automatic renewal script should not auto-renew if a patron's record has expired Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: janet.mcgowan@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently with the automatic_renewals.pl script, materials are still auto-renewed even if the patron's account has expired. The automatic renewals script has error conditions which prevent automatic renewals in these circumstances: $error eq 'too_many' or $error eq 'on_reserve' or $error eq 'restriction' or $error eq 'overdue' or $error eq 'auto_too_late' or $error eq 'auto_too_much_oweing' or $error eq 'auto_too_soon The error conditions should take into account the expiry date of borrower and not auto renew if the borrower's account has expired. For example adding a new error code such as 'borrower_expired' - or whatever convention achieves this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de Status|NEW |In Discussion Severity|enhancement |normal --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do we need a new syspref here or must it be the default behaviour? Or based on BlockExpiredPatronOpacActions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com --- Comment #2 from Jonathan Field <jonathan.field@ptfs-europe.com> --- We believe it should be the default behaviour rather than requiring some sort of system preference. If the user has expired, they shouldn't be making any new transactions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, there is has been a lot of dicussion about this and libraries have different ideas about this, for some a hold that can be placed is an incentive for the user to come back to the library and renew their membership etc. Have you checked the BlockExpiredPatronOpacActions system prefernece? [Block|don't block] expired patrons from OPAC actions such as placing a hold or renewing. Note that the setting for a patron category takes priority over this system preference. I think it would make sense to treat auto-renewals according to this setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #4 from Jonathan Field <jonathan.field@ptfs-europe.com> --- Hi Katrin, very happy to do that if there is a use case for other libraries. We just need to make sure there is a mechanism in place for expired users and auto-renewals. happy to go with your suggestion though! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is not clear to me if we want another pref "ExpiredBlockRenewing" (like OverduesBlockRenewing and RestrictionBlockRenewing) to block renewals globally or if we want to fix this behaviour only for auto renewals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's a good question. I think as ExpiredPatronBlockOpacActions already covers normal renewals it makes sense to include AutoRenewals there. If we want to have both separate, I'd make the new pref specific, so that it doesn't interfere with the existing pref: ExpiredBlockAutoRenewing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #7 from Jonathan Field <jonathan.field@ptfs-europe.com> --- I agree with Katrin, would be very happy with that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68633&action=edit Bug 19444: Do not auto renew if patron is expired and BlockExpiredPatronOpacActions is set If the patron's account has expired and BlockExpiredPatronOpacActions is set, we expect auto renewal to be rejected. Test plan: Use the automatic_renewals.pl cronjob script to auto renew a checkout Before this patch, if the patron's account has expired the auto renew was done. With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions is not set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 68633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68633 Bug 19444: Do not auto renew if patron is expired and BlockExpiredPatronOpacActions is set Review of attachment 68633: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19444&attachment=68633) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +14854,4 @@
});
SetVersion( $DBversion ); + print "Upgrade to $DBversion done (Bug 12768 - Add 'Processing Fee' to the account_offset_types table if missing)\n";
This isn't related to this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m --- Comment #10 from Dominic Pichette <dominic.pichette@inlibro.com> --- I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked out an item for a particular patron, change the expiration date of that patron so he is now expired and then executed automatic_renewals.pl. The patch didn't seem to make a difference, it passed in both cases.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #11 from Dominic Pichette <dominic.pichette@inlibro.com> --- I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked out an item for a particular patron, change the expiration date of that patron so he is now expired and then executed automatic_renewals.pl. The patch didn't seem to make a difference, it passed in both cases.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Dominic Pichette from comment #11)
I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked out an item for a particular patron, change the expiration date of that patron so he is now expired and then executed automatic_renewals.pl. The patch didn't seem to make a difference, it passed in both cases..
Dominic, you need to know how automatic renewals work if you want to test this patch. You should enable it in the issuing rule and then tick the "Automatic renewal" on the checkout screen. Is it what you tried? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com --- Comment #13 from Claire Gravely <claire_gravely@hotmail.com> --- Tested patch, seems to work as expected :) One comment: when I turned the syspref on to "Block" the renew column in the list of checkouts (circulation.pl) it shows auto_account_expired (5 of 5 renewals remaining) do we want to show that wording? Would just 'Account expired' be more user friendly? Otherwise happy to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69502&action=edit Bug 19444: Display error message for auto_account_expired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Claire Gravely from comment #13)
do we want to show that wording? Would just 'Account expired' be more user friendly?
Thanks for testing Claire! Yes you are right, the last patch display a human friendly message for this error code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #16 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69503&action=edit [SIGNED-OFF] Bug 19444: Do not auto renew if patron is expired and BlockExpiredPatronOpacActions is set If the patron's account has expired and BlockExpiredPatronOpacActions is set, we expect auto renewal to be rejected. Test plan: Use the automatic_renewals.pl cronjob script to auto renew a checkout Before this patch, if the patron's account has expired the auto renew was done. With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions is not set. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #17 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 69504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69504&action=edit [SIGNED-OFF] Bug 19444: Display error message for auto_account_expired Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68633|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jason Palmer <jpalmer@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpalmer@switchinc.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69810&action=edit Bug 19444: Do not auto renew if patron is expired and BlockExpiredPatronOpacActions is set If the patron's account has expired and BlockExpiredPatronOpacActions is set, we expect auto renewal to be rejected. Test plan: Use the automatic_renewals.pl cronjob script to auto renew a checkout Before this patch, if the patron's account has expired the auto renew was done. With this patch, it will only be auto renewed if BlockExpiredPatronOpacActions is not set. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69811&action=edit Bug 19444: Display error message for auto_account_expired Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69812&action=edit Bug 19444: (QA follow-up) Fix tests for UNIMARC Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 69813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69813&action=edit Bug 19444: (QA follow-up) Remove repeating condition Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69504|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #24 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x for v17.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29557 [Bug 29557] auto-renew notices should handle failed renewal due to patron expiration -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org