[Bug 22058] New: OPAC holdings table shows instead of blank
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Bug ID: 22058 Summary: OPAC holdings table shows instead of blank Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: marka@pobox.com QA Contact: testopia@bugs.koha-community.org Depends on: 13618 Target Milestone: --- Created attachment 83573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83573&action=edit OPAC MARC view holding detail in 18.11 In the OPAC, when looking at the MARC view for an item, there is a table at the bottom of the page showing some holding information. Those table fields that used to be blank in 18.05 are now displaying as " " (without the quotes) in 18.11. In my particular case, the fields that are displayed this way are: * Withdrawn status * Lost status * Damaged status * Not for loan Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21279 CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe a similar fix as bug 21279? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|18.11 |master Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's line 320 in opac-MARCDetail.pl: $item_data->{$subfield_code} ||= " " If you change that to " " or "" it will display correctly. But: I compared the display to staff and there we actually use a $raw filter on the template which will also display correctly. It has the added benefit that HTML used in note fields (I know, we do that) will display correctly. So I will propose a patch making staff and OPAC match. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83609&action=edit Bug 22058: Fix display of empty table cells in OPAC MARC view holdings I compared the template logic to the MARC detail page in staff. We use $raw there instead of html, which will also make notes and other fields with HTML in them display correctly. I am proposing to use the $raw filter in OPAC as well. To test: - Go to the OPAC - Search for a record with items - Switch to the MARC view - Verify empty cells show (html entity for space) - Apply patch - Repeat test - Verify empty table cells now show as empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83609|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83621&action=edit Bug 22058: Fix display of empty table cells in OPAC MARC view holdings I compared the template logic to the MARC detail page in staff. We use $raw there instead of html, which will also make notes and other fields with HTML in them display correctly. I am proposing to use the $raw filter in OPAC as well. To test: - Go to the OPAC - Search for a record with items - Switch to the MARC view - Verify empty cells show (html entity for space) - Apply patch - Repeat test - Verify empty table cells now show as empty Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This one probably deserves a t/db_dependent/selenium/regressions.t test. Specially if we allow HTML in note fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83621|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 83736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83736&action=edit Bug 22058: Fix display of empty table cells in OPAC MARC view holdings I compared the template logic to the MARC detail page in staff. We use $raw there instead of html, which will also make notes and other fields with HTML in them display correctly. I am proposing to use the $raw filter in OPAC as well. To test: - Go to the OPAC - Search for a record with items - Switch to the MARC view - Verify empty cells show (html entity for space) - Apply patch - Repeat test - Verify empty table cells now show as empty Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #9 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 18.05. Will not be backported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22058 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jesse Maseto from comment #9)
Merge conflicts with 18.05. Will not be backported.
This patch is not needed for 18.05.x since the var is not escaped : [% item.$sf_code %] -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org