http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> --- Nicole, I don't understand why it's a bug ? If a patron place a hold on "the two towers", and the item moved was, in fact a "twilight" book, moving the hold should stay for "the two towers", isn't it ? unless you're talking of a waiting hold, you'll confirm. And in this case, yes, it must be fixed... (and that will be tricky: we can't just move the hold, because the patron reserved "the two towers". So we have to cancel the hold and warn the patron. Or attach another item to the hold. yes, that will be tricky to fix... (my feeling is that a quick workaround would be to reset the hold to non-"W" status) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #2)

The problem is that the hold is 'item specific' - not a hold on the next available and so you end up with an orphaned hold because the reserves table still has a hold on that itemnumber, but the wrong biblionumber - so if this instance the hold should be moved to the right biblionumber or the itemnumber should be removed from the hold and the hold made on the bib level instead of item specific. That would solve the technical problem. But the library will still have to explain that the user placed a hold on 'the two towers' and get '50 shades of grey'. Well, the use case for moving an item is also that you've duplicate biblio records, so maybe the use case 'I place a hold on the 2 towers and get 50 shades of grey' is rare enough to be managed manually. do you agree ?

-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #5 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- This is *definitely* a bug. People don't usually move items from a bib with one title to a bib with another, because, well, items, by their very nature, don't change title (broad, but justifiable, generalization). I agree with Nicole that if you have an item with an item level hold, the hold should go with the item, the hold should not stay with the bib. The issue of "you could attach an item to the wrong title" is a human error, not a technical one, and should be fixed by the human. Plus, if the hold moved with the item to the new bib, if someone made an error, it's easy enough to fix it by simply moving the item back to it's original bib, no harm, no foul. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #7 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Bump - this needs some love, deduping is a pain without this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- It's not just item-level hold requests -- it's also bib-level hold requests that have been captured. The following tables definitely should be updated when an item is moved to a different bib: reserves hold_fill_targets tmp_holdsqueue linktracker The following tables perhaps should be updated: aqorders_items reserveconstraints import_items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40920&action=edit Bug 8723: Update the reserves table for item-level holds If an item is moved from a biblio to another, the holds should be updated too. See discussion on the bug report for more information. Test plan: 1/ Place a item-level hold on biblio1 2/ Move the item to biblio2 3/ Confirm that the hold still exists and point to the biblio2 This patch should not change the existing behavior for bib-level holds. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Galen Charlton from comment #9)

It's not just item-level hold requests -- it's also bib-level hold requests that have been captured.

The following tables definitely should be updated when an item is moved to a different bib:

reserves hold_fill_targets tmp_holdsqueue linktracker

Agreed and done.

The following tables perhaps should be updated:

aqorders_items

No biblionumber field.

reserveconstraints

It will be removed by bug 9809.

import_items

Maybe, but I don't understand what to do here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40919|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 41078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41078&action=edit Bug 8723: Cover the existing behavior This patch cover the MoveItemFromBiblio subroutine Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40921|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 41080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41080&action=edit Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables Same as previous patch for 3 other tables. Test plan: Same as before but the hold should exist to the 3 tables before the move. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I confirmed the linktracker update works correctly, to test: - Activate TrackClicks - Catalog an URL each in 856 and in 952$u - Open each link in the OPAC - Move item - Check linktracker table: item link will have moved, record level link did not -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41078|0 |1 is obsolete| | Attachment #41079|0 |1 is obsolete| | Attachment #41080|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42439&action=edit [PASSED QA] Bug 8723: Cover the existing behavior This patch cover the MoveItemFromBiblio subroutine Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42441&action=edit [PASSED QA] Bug 8723: Update hold_fill_targets, tmp_holdsqueue and linktracker tables Same as previous patch for 3 other tables. Test plan: Same as before but the hold should exist to the 3 tables before the move. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #23 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.