https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff CC| |david.bourgault@inlibro.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67313|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 67585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67585&action=edit Bug 16820 - Edit accountlines from borrower's profile Adds the option to edit an accountline from a borrower's profile page in the intranet. Test plan : 0) Try to edit an accountline, you can't 1) Apply patch 2) Try to edit an accountline, you can Also solves Bug 2193 Followed test plan, patch worked as described. Also ran QA test tools and all 3 modified files passed Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Editing fines should create account offsets to reflect the change in amount to a fine if applicable. It would also be nice if the code use Koha::Account::Line(s) instead of direct sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please also consider to add a separate permission for this, some libraries might consider it dangerous or not want everyone to be able to do this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Needed to pass qa: 1) Implement use of Account Offsets. Any change to a fee or payment needs to add to the account offsets table from now on. The point of it is to create a full accounting of all changes to accountlines 2) Add a user permission for this functionality 3) Implement using Koha::Account::Line(s)/Offset(s) instead of using direct SQL queries. These new subs should live in Koha::Account::Line since they are operating on individual accountlines. We need to reduce the number of subs in the C4 namespace instead of adding to them ; ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- 4) Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 2193 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm going to assume David Bourgault isn't going to get back to this and unassign it so we can fold it into the accounts tree afresh. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 24081 *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #14 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- (In reply to Martin Renvoize from comment #11)

With the introduction of a discounts process in accounts with bug 24081 I think this is resolved.

Hi Martin, Katrin is right. The new feature for making a discount does not allow you to increase the amount of the fine. For example, it is convenient to be able to change an amount when a replacement price no longer matches the market value of an item. Marjorie -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes.