https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud@orex.es, | |katrin.fischer@bsz-bw.de Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129816&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129818&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The goal of these patches is to adapt the code from https://gitlab.com/sibeprod/datosautores to Koha core. It can be viewed there: https://biblioteca.ecosur.mx/cgi-bin/koha/opac-authoritiesdetail.pl?authid=1... https://biblioteca.ecosur.mx/cgi-bin/koha/opac-detail.pl?biblionumber=10794 To be integrated correctly into Koha I have decided to add the identifiers in a new tab, but this can be adjusted if someone has a better suggestion. Also I am suggesting to deal with other author's information from 371, 372, 373 (email, activity, etc.) on a separate bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Hugo Agud <hagud@orex.es> --- Bug 29897 - Display author identifiers for researchers 129816 - Bug 29897: Rename get_marc_authors with get_marc_contributors 129817 - Bug 29897: Move code to private method for reusability 129818 - Bug 29897: Add new pref OPACAuthorIdentifiers 129819 - Bug 29897: Display author's identifiers Applying: Bug 29897: Rename get_marc_authors with get_marc_contributors Using index info to reconstruct a base tree... M Koha/Biblio.pm M basket/basket.pl M basket/sendbasket.pl M opac/opac-basket.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M t/db_dependent/Koha/Biblio.t M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl Auto-merging t/db_dependent/Koha/Biblio.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Biblio.t Auto-merging opac/opac-basket.pl Auto-merging basket/basket.pl Auto-merging Koha/Biblio.pm CONFLICT (content): Merge conflict in Koha/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 29897: Rename get_marc_authors with get_marc_contributors [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-29897-Rename-getmarcauthors-with-getmarccontri-5Xn3sp.patch Apply? [(y)es, (n)o, (i)nteractive] DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_29897.pl [10:24:08]: Bug 29897 - Add new system preference OPACAuthorIdentifiers -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #8 from Hugo Agud <hagud@orex.es> --- I am not able to apply the patch in any sandboxes available Bug 29897 - Display author identifiers for researchers 129816 - Bug 29897: Rename get_marc_authors with get_marc_contributors 129817 - Bug 29897: Move code to private method for reusability 129818 - Bug 29897: Add new pref OPACAuthorIdentifiers 129819 - Bug 29897: Display author's identifiers fatal: previous rebase directory .git/rebase-apply still exists but mbox given. Patch left in /tmp/Bug-29897-Rename-getmarcauthors-with-getmarccontri-4JmoX6.patch Apply? [(y)es, (n)o, (i)nteractive] sorry :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129816|0 |1 is obsolete| | Attachment #129817|0 |1 is obsolete| | Attachment #129818|0 |1 is obsolete| | Attachment #129819|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132961&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132963&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #14 from Hugo Agud <hagud@orex.es> --- The basic functionality is there and it is awesome, good job! however there are some minor issues to fix At bibliographic level: I do not think it will available, yet https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/opac-detail.pl?bibl... Inside Authorities identifiers tab a) None Links are functional: https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/https%3A%2F%2Fwww.s... b) Tag 110 is not included in Authorities identifiers tab At authority level: https://opac-bug29897.sandboxes.biblibre.eu/cgi-bin/koha/opac-authoritiesdet... a) Only orcid link is published, all other identifiers are published without the link -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks Hugo! This last patch should fix the problems you found. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #18 from Hugo Agud <hagud@orex.es> --- Thanks, have you seen this bug? b) Tag 110 is not included in Authorities identifiers tab? however tag 710 is included, but not 110 thanks you in advance -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #20 from Hugo Agud <hagud@orex.es> --- then it could be a more general bug, however this patch, does, what it suppouse to do in a very smart and beatiful way. the only it could be target blank in the url, but it works very fine! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132962|0 |1 is obsolete| | --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 133114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133114&action=edit Bug 29897: Move code to private method for reusability Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132964|0 |1 is obsolete| | --- Comment #24 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 133116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133116&action=edit Bug 29897: Display author's identifiers This new enhancement add the capability to list the different identifiers of authors. It is helpful for research publications for instance. This patch will add a new "Author identifiers" tab on the detail page (OPAC) of a bibliographic record, with the list of the authors and their identifiers. On the detail page of the authority record, the same identifier list will be displayed. Test plan: Create some authority with 024 $a source $2 number $6 link to the source With the pref turned ON you will be able to see the new information. Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Hugo Agud <hagud@orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd really love to have this feature, but going through the code sadly found a bigger issue with the specification :( I am making this 0) now, although I caught it last at the bottom of the source tree: 0) Linkage $6 In your code you assume that $6 is a URL, but that will NEVER be the case according to MARC standard. $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html So I don't think we can push this as is. :( If at all, a link would probably be in $1, but that's a quite new field and quite unlikely. I think our best bet for a universally working feature right now is to buidl the URLs to the corresponding portals using the cataloged IDs form $a ourselves. This also means, that we should limit our efforts on a short list of $2 codes for now. The 4 you have in there would be fine with me. We could add others later. We should also limit $2 display to the ones we have implemented and checked, some are just not useful to patrons. 1) Missing POD for _get_marc_authors Could it be a little confusing having _get_marc_authors and get_marc_authors? 2) On get_marc_contributurs, you write: (700..712 for MARC21) but: + if ( $marcflavour eq "UNIMARC" ) { + $mintag = "700"; + $maxtag = "712"; + $fields_filter = '7..'; + } else { # marc21/normarc + $mintag = "700"; + $maxtag = "720"; + $fields_filter = '7..'; + } Overall using a range instead of a list seems a little risky, but works for MARC21. It looks like a lot of fields, but actually it's only: 700, 710, 711 and 720. (https://www.loc.gov/marc/bibliographic/bd70x75x.html) 3) Missing 110, 111 If we get 710 and 711 we should probably include 110 and 111 in get_marc_authors as well. As it was 'wrong' before, should we file a separate bug report to extend this method? 4) Pref description I am struggling a bit with the description. [Display|Don't display] author identifiers for research publications. It makes it sound, like it was limited to research publications, while the limit is actually the 024 existing or not. Adding information that this requires authorities and 024 would be good I think. Maybe: [Display|Don't display] identifiers for authors and contributors to the detail pages in the OPAC. This feature requires authorities with 024 5) Selection of $2 + [% CASE 'orcid' %]ORCID: + [% CASE 'scopus' %]ScopusID: + [% CASE 'loop' %]loop: + [% CASE 'rid' %]Publons: a) Should these be surrounded by <span>? b) $2 are usually taken from the official LOC list: https://www.loc.gov/standards/sourcelist/standard-identifier.html orcid = ORCID OK scopus = ScopusID OK loop = doesn't exist in official list. I am fine with it if that is a custom one, but maybe worth checking? rid = ResearcherID, linking to: http://www.researcherid.com/#rid-for-researchers, stating: ResearcherID profiles moved to Publons on 15 April 2019 - so probably OK viaf might be a good candidate (for another bug). The fallback worries me: [% CASE %][% identifier.source | html %]: I think we should stick with a hardcoded list as not all $2 codes and identifiers are useful to patrons (and they might get into the catalog, if you use a central authority file) c) I'd also suggest to add a class with the $2 to the <li> element, this way each entry could be hidden and customized easily. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134459&action=edit Bug 29897: Don't use $6 for linkage but build the link instead See comment 26: $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134461&action=edit Bug 29897: Improve syspref's description Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134463&action=edit Bug 29897: Move the identifier list to an include file Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #26) Thanks for your time, Katrin!

0) Linkage $6

In your code you assume that $6 is a URL, but that will NEVER be the case according to MARC standard.

We are going to lose flexibility, but I agree we should follow the standard.

1) Missing POD for _get_marc_authors

Could it be a little confusing having _get_marc_authors and get_marc_authors?

Added POD.

2) On get_marc_contributurs, you write:

(700..712 for MARC21)

but:

+ if ( $marcflavour eq "UNIMARC" ) { + $mintag = "700"; + $maxtag = "712"; + $fields_filter = '7..'; + } else { # marc21/normarc + $mintag = "700"; + $maxtag = "720"; + $fields_filter = '7..'; + }

Overall using a range instead of a list seems a little risky, but works for MARC21. It looks like a lot of fields, but actually it's only: 700, 710, 711 and 720. (https://www.loc.gov/marc/bibliographic/bd70x75x.html)

Adjusted the POD!

3) Missing 110, 111

If we get 710 and 711 we should probably include 110 and 111 in get_marc_authors as well. As it was 'wrong' before, should we file a separate bug report to extend this method?

Hum, yes? I don't know! Any ideas why it's missing here?

4) Pref description

I am struggling a bit with the description.

[Display|Don't display] author identifiers for research publications.

It makes it sound, like it was limited to research publications, while the limit is actually the 024 existing or not.

Adding information that this requires authorities and 024 would be good I think. Maybe:

[Display|Don't display] identifiers for authors and contributors to the detail pages in the OPAC. This feature requires authorities with 024

Done, thanks for the suggestion.

5) Selection of $2

+ [% CASE 'orcid' %]ORCID: + [% CASE 'scopus' %]ScopusID: + [% CASE 'loop' %]loop: + [% CASE 'rid' %]Publons:

a) Should these be surrounded by <span>? b) $2 are usually taken from the official LOC list: https://www.loc.gov/standards/sourcelist/standard-identifier.html

orcid = ORCID OK scopus = ScopusID OK loop = doesn't exist in official list. I am fine with it if that is a custom one, but maybe worth checking? rid = ResearcherID, linking to: http://www.researcherid.com/#rid-for-researchers, stating: ResearcherID profiles moved to Publons on 15 April 2019 - so probably OK

Hugo, do you know "loop"?

viaf might be a good candidate (for another bug).

I have added here.

The fallback worries me: [% CASE %][% identifier.source | html %]:

I think we should stick with a hardcoded list as not all $2 codes and identifiers are useful to patrons (and they might get into the catalog, if you use a central authority file)

Done, but I am not sure I agree with this :) Won't we get request from lot of people to add theirs?

c) I'd also suggest to add a class with the $2 to the <li> element, this way each entry could be hidden and customized easily.

Can you be more specific please? There is a class on the div already (author_identifier). With the new patches, do you think we should have: <span class="orcid">ORCID</span> ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133113|0 |1 is obsolete| | Attachment #133114|0 |1 is obsolete| | Attachment #133115|0 |1 is obsolete| | Attachment #133116|0 |1 is obsolete| | Attachment #133117|0 |1 is obsolete| | Attachment #134459|0 |1 is obsolete| | Attachment #134460|0 |1 is obsolete| | Attachment #134461|0 |1 is obsolete| | Attachment #134462|0 |1 is obsolete| | Attachment #134463|0 |1 is obsolete| | Attachment #134464|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135983&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135985&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135987&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135989&action=edit Bug 29897: Add and fix POD Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135991&action=edit Bug 29897: Add VIAF Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135993&action=edit Bug 29897: Don't display identifier if not in the list Requested by QA, see comment 26. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Biblioteca de Asociación Médica from comment #45)

Greetings to all Koha´s community.

We wish to inform you the great contributions you have made to the ABC Hospital Medical Association Library. Since Koha´s implementation we have received a lot of congratulations and approval from our users and superiors.

We are motivated to continue the development of our services. One of them consist into add the ORCID and the links to doctors' social media profiles.

We would like to ask the status of this Koha´s new modality.

Thanks in advance for your reply.

Hola, This development is waiting for a review from one member of the QA team. You can show your interest in this development and explain how useful it will be for you, by letting a comment (as you did!) and/or vote for it (see above of the page, there is a "vote" link). Then you can cross fingers and hope it will be part of the next major version, 22.11. Thank you for showing us your interest here! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you please rebase? :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135983|0 |1 is obsolete| | Attachment #135984|0 |1 is obsolete| | Attachment #135985|0 |1 is obsolete| | Attachment #135986|0 |1 is obsolete| | Attachment #135987|0 |1 is obsolete| | Attachment #135988|0 |1 is obsolete| | Attachment #135989|0 |1 is obsolete| | Attachment #135990|0 |1 is obsolete| | Attachment #135991|0 |1 is obsolete| | Attachment #135992|0 |1 is obsolete| | Attachment #135993|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138249&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138251&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138253&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138255&action=edit Bug 29897: Add and fix POD Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138257&action=edit Bug 29897: Add VIAF Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138259&action=edit Bug 29897: Don't display identifier if not in the list Requested by QA, see comment 26. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, I can't get the information to show in the OPAC :( * Applied patch, updatatabase, restart_all* * Activated OPACAuthorIdentifiers * Updated authority record with 024 as such: #148 Foy, Brian D. $2 orcid $a 0000-... Also tried an author that is in 100 - no effect. But I don't see the information neither in the OPAC detail view nor the OPAC authority detail view. Maybe I am doing it wrong? Help! :) Some other things I noticed: 1) get_identifiers The routine is still using $6, maybe we should remove this to avoid confusion about its purpose. 2) Update commit message The test plan also still mentions $6, we should probably update for documentation writers. 3) System preference The system preference mentions 024, but I think it would be useful to add the valid $2 source codes, so it's easier to use. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138371&action=edit Bug 29897: Remove 'linkage' leftover -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new enhancement add release notes| |the capability to list the | |different identifiers of | |authors. It is helpful for | |research publications for | |instance. | |It will add a new | |"Author identifiers" tab on | |the detail page (OPAC) of a | |bibliographic record, with | |the list of the authors and | |their identifiers. | |On the | |detail page of the | |authority record, the same | |identifier list will be | |displayed. | |The authority | |must have a 024$a (source) | |and 024$2 (number). Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138252|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138425&action=edit Bug 29897: Display author's identifiers This new enhancement add the capability to list the different identifiers of authors. It is helpful for research publications for instance. This patch will add a new "Author identifiers" tab on the detail page (OPAC) of a bibliographic record, with the list of the authors and their identifiers. On the detail page of the authority record, the same identifier list will be displayed. Test plan: Create some authority with 024 $a source $2 number $6 link to the source With the pref turned ON you will be able to see the new information. Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138254|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138427&action=edit Bug 29897: Don't use $6 for linkage but build the link instead See comment 26: $6 is a very specialized field that will never contain a URL. Linkage here means 'linking MARC fields within the record'. For example it is used to link an original script tag with the corresponding tag in transliteration. See: https://www.loc.gov/marc/authority/ecadcntf.html Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138256|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138429&action=edit Bug 29897: Improve syspref's description Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138258|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138431&action=edit Bug 29897: Move the identifier list to an include file Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138260|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138433&action=edit Bug 29897: Fix tab display -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138372|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138435&action=edit Bug 29897: Adjust syspref description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138435|0 |1 is obsolete| | --- Comment #77 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138486&action=edit Bug 29897: Adjust syspref description Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138487&action=edit Bug 29897: (QA follow-up) Add valid $2 codes to pref description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138490&action=edit Bug 29897: Don't display empty li It's ugly to move the li to the include file, but it's the easiest for now... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #81)

(In reply to Katrin Fischer from comment #78)

...

I am sorry, I found another small issue. I tried to fix, but miss the right idea now:

[% FOR identifier IN author.identifiers %] <li> [% PROCESS "authority-identifiers.inc" identifier => identifier %] </li> [% END %]

This will create empty li elements, when $2 is not in the list of valid codes.

I am providing a follow-up with some more information for the pref description.

Done.

I don't think it was a good idea to modify the original request and remove the flexibility to have different source. We will see what is the feedback once it's pushed.

Have you seen the list of valid codes in the MARC documentation? :) The problem is that the user won't understand them and we need to build the URLs to make it useful. If we don't limit on $2, then we'd need some kind of configuration page. I think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch is missing the changes to the include file! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138249|0 |1 is obsolete| | --- Comment #86 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138664&action=edit Bug 29897: Rename get_marc_authors with get_marc_contributors get_marc_authors actually return authors from 700..712, not the first author from 200 Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138251|0 |1 is obsolete| | --- Comment #88 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138666&action=edit Bug 29897: Add new pref OPACAuthorIdentifiers Sponsored-by: Orex Digital Signed-off-by: Orex Digital <info@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138426|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138668&action=edit Bug 29897: Fix linkage Signed-off-by: Orex Digital <info@orex.es> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138428|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138670&action=edit Bug 29897: Add and fix POD Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138430|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138672&action=edit Bug 29897: Add VIAF Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138432|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138674&action=edit Bug 29897: Don't display identifier if not in the list Requested by QA, see comment 26. Sponsored-by: Orex Digital Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138434|0 |1 is obsolete| | --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138676&action=edit Bug 29897: Remove 'linkage' leftover Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138487|0 |1 is obsolete| | --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 138678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138678&action=edit Bug 29897: (QA follow-up) Add valid $2 codes to pref description Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new enhancement add |This new enhancement adds release notes|the capability to list the |the capability to list the |different identifiers of |different identifiers of |authors. It is helpful for |authors. It is helpful for |research publications for |research publications for |instance. |instance. |It will add a new |It will add a new |"Author identifiers" tab on |"Author identifiers" tab on |the detail page (OPAC) of a |the detail page (OPAC) of a |bibliographic record, with |bibliographic record, with |the list of the authors and |the list of the authors and |their identifiers. |their identifiers. |On the |On the |detail page of the |detail page of the |authority record, the same |authority record, the same |identifier list will be |identifier list will be |displayed. |displayed. |The authority |The authority |must have a 024$a (source) |must have a 024$a (source) |and 024$2 (number). |and 024$2 (number). CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, I like where this is headed to. Questions, are there plans to: - add valid values dropdowns to the cataloguing interface? - add a way to retrieve those identifiers from the configured services? - add the feature to the staff interface? Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #105 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #103)

(In reply to Tomás Cohen Arazi from comment #102)

...

Ok, I like where this is headed to. Questions, are there plans to:

- add valid values dropdowns to the cataloguing interface?

The list of valid MARC codes is very long and the list that will produce a link in the OPAC is still very short. I think we should leave things as is. Adding drop downs is dangerous if you don't know which values have been used already or might be used in incoming records. If the entry is not in the list, the data will be lost. And a full list of valid MARC codes would also be quite long. https://www.loc.gov/standards/sourcelist/standard-identifier.html

We could have an AV category in Koha, with (at least) the supported values. Just thinking how end users will use this.

...

- add a way to retrieve those identifiers from the configured services?

Can you explain? Do you mean for enriching data?

I think that would not be easily done. If you have common names, the identifiers are added to allow to pick 'the right one'. If you try to match just on the name alone it's too risky.

The whole point in my opinion is to eventually have a '...' link opening a search on the desired identifiers provider (e.g. ORCID) so the link with the ID is automatically generated. JUST A THOUGHT.

...

- add the feature to the staff interface?

That would be a nice enhancement, but I think it's great as is already. We had 3 different libraries requesting to be able to see the ORCID in the OPAC until now. Looking forward to close these tickets :)

Yeah, my question was more a roadmap one: I've already pushed this, just wanted to know the next planned steps (IF ANY!) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #105)

(In reply to Katrin Fischer from comment #103)

...

(In reply to Tomás Cohen Arazi from comment #102)

...

Ok, I like where this is headed to. Questions, are there plans to:

- add valid values dropdowns to the cataloguing interface?

The list of valid MARC codes is very long and the list that will produce a link in the OPAC is still very short. I think we should leave things as is. Adding drop downs is dangerous if you don't know which values have been used already or might be used in incoming records. If the entry is not in the list, the data will be lost. And a full list of valid MARC codes would also be quite long. https://www.loc.gov/standards/sourcelist/standard-identifier.html

We could have an AV category in Koha, with (at least) the supported values. Just thinking how end users will use this.

We could, but we should not link it to the frameworks by default. If you import a record with a value not in the list, on saving the information in $2 will otherwise be lost and leave you with a $a you can't identify.

...

...

- add a way to retrieve those identifiers from the configured services?

Can you explain? Do you mean for enriching data?

I think that would not be easily done. If you have common names, the identifiers are added to allow to pick 'the right one'. If you try to match just on the name alone it's too risky.

The whole point in my opinion is to eventually have a '...' link opening a search on the desired identifiers provider (e.g. ORCID) so the link with the ID is automatically generated. JUST A THOUGHT.

We do link now... ? Not sure what the difference would be. Another idea: we could move the include file with the link construction to a YAML style pref. That way people could easily add more and their own. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 --- Comment #109 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) There is a new version of Koha every 6 months. On November and May https://koha-community.org/about/release-schedule/ The last 3 major versions are still maintained and get monthly releases. So it's possible that 22.05, 21.11 and 21.05 will get this enhancement. Stay tuned to this ticket to know if that will be the case. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #111 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, great! There is a nice display ! Just a question: this enhancement seems to be only MARC21 compliant? In unimarc, there are two fields in the authorities format that could be used at my opinion : 017 (https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/AUT...) or 033 (https://cdn.ifla.org/wp-content/uploads/files/assets/uca/unimarc_updates/AUT...) In fact, I think it could be settable because in France we use often PPN that idref identifier that is most of the time in a 003 field. Thanks, Sonia -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29897 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/620 -- You are receiving this mail because: You are watching all bug changes.