[Bug 28021] New: OPAC detail page contains incorrect Bootstrap classes (20.05.x)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Bug ID: 28021 Summary: OPAC detail page contains incorrect Bootstrap classes (20.05.x) Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In 20.05.x the OPAC detail page contains the Bootstrap class 'col-lg-9' and not 'span9'. Since 20.05.x is not upgraded to Bootstrap 4 it cannot apply the correct CSS to OPAC detail page, making it display oddly. To fix this in the short term you can use the following OPACUserJS: if ( $('#opac-detail').length ) { $('#catalogue_detail_biblio').parent().addClass('span9').removeClass('col-lg-9'); } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- https://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/opa... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27029 [Bug 27029] Detail page missing Javascript accessible biblionumber value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 118629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118629&action=edit Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118629|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 118634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118634&action=edit Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118634|0 |1 is obsolete| | CC| |amitddng135@gmail.com --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118635&action=edit Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Work OK. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes some bad release notes| |Bootstrap classes | |introduced to 20.05 via a | |bad backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 119320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119320&action=edit Bug 28021: Fix Bootstrap classes To test: -be on 20.05.x -go to any OPAC detail page -the maincontent stretchs across the entire page -the action buttons (place hold, save to lists, print, ect) are pushed to the bottom of the page -apply patch and reload page -things are better Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nice catch, Lucas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to stable --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Moving to 20.05 RMaint queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com Version(s)| |20.05.11 released in| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.11, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28021 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 19.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org