https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #0)

https://snag.gy/YOlr50.jpg

We obviously have another problem here too: Two transfer messages? Shouldn't the rotating collection transfer message supersede the "normal" one? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51791&action=edit Bug 16566 - 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51791|0 |1 is obsolete| | --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 51902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51902&action=edit Bug 16566 - 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 52551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52551&action=edit Screenshot: Please return item to: Midway First test I did: Return a checked out item at another branch than it's been checked out from. The button shown doesn't work for me - no visible Javascript error. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 --- Comment #6 from Marc Véron <veron@veron.ch> --- In the browser's page source, the url provided is: data-url="transfer-slip.pl?transferitem=298&branchcode=CPL&op=slip" If I copy it in the browser's address field I have to replace & with & to make it work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51902|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 52694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52694&action=edit Bug 16566 [Revised] 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Revision following QA: Removed redundant class attribute from the print button tested in step 1. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52694|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 52860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52860&action=edit Bug 16566 [Revised] 'Print slip' button formatting inconsistent This patch modifies the style of some "print slip" links on the checkin page to make them consistent with other buttons shown in dialogs. This patch also removes the use of "onclick" in some places in favor of defining events in the JavaScript. To test apply the patch and go to Circulation -> Check in. - Check in an item which belongs at another branch. You should see a dialog which asks the user to transfer the item. Confirm that the "Print slip" button looks correct and works correctly. - Check in the same item again. You should see a different dialog which has both a "Print transfer slip" and "Cancel transfer" button. The "Print transfer slip" button should look correct and work correctly. - Check in an item which is part of a rotating collection. (Or, if Bug 16570 is still open, check in any item) You should see a dialog which notifies you that the item is part of a rotating collection. The "Print slip" button in this dialog should look correct and work correctly. Followed test plan. Buttons appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Revision following QA: Removed redundant class attribute from the print button tested in step 1. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16566 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #11 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- This patch creates another bug: When confirming transfer and print slip, the print-slip popup winwod appears, but when it returns, the transfer is not effected. (because of e.preventDefault(), the form event is never processed) -- You are receiving this mail because: You are watching all bug changes.