https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37830 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171024&action=edit Bug 37830: Add ability to filter holdings in OPAC Test plan: 1) Visit any OPAC biblio page, ktd: opac_url/cgi-bin/koha/opac-detail.pl?biblionumber=336 2) Notice a new "Search holdings" input on top of the holdings table 3) Type something in the input, notice it filters rows 4) Clear the filter, notice all rows show -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37830 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37830 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171031|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172450&action=edit Bug 37830: Add ability to filter holdings in OPAC Test plan: 1) Visit any OPAC biblio page, ktd: opac_url/cgi-bin/koha/opac-detail.pl?biblionumber=336 2) Notice a new "Search holdings" input on top of the holdings table 3) Type something in the input, notice it filters rows 4) Clear the filter, notice all rows show Sponsored-by: NHS England Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37830 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Status|Signed Off |ASSIGNED --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass (lukeg) from comment #4)

Pedro,

Is there any reason to not use DataTable's native filter?

dom: '<"row-filter"><"clear">lf',

Other than not knowing about it, no reason at all! I've taken a look at this and works very well (and much better than my original patch). I'll revisit. Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37830 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |INVALID --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi all, our requirements for this particular holdings table search input have grown to customer specific customizations beyond what the datatable search input provides. For this reason I've decided to have my own JavaScript in opacuserjs for this particular use case, for now. I'll follow-up here if community feels this is very valuable to be in core, otherwise I won't proceed with it here. -- You are receiving this mail because: You are watching all bug changes.