[Bug 9117] New: Reports hierarchies management improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Bug ID: 9117 Summary: Reports hierarchies management improvements Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Reports Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13560&action=edit Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13578&action=edit Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13597&action=edit Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13627&action=edit [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13628&action=edit Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13597|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13578|Bug 9117: Reports |[SIGNED-OFF] Bug 9117: description|hierarchies management |Reports hierarchies |improvements |management improvements -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch complexity|--- |Large patch --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- I wanted to be a on the CC list for this bug, but had to set a patch complexity to do so - update if I was wrong in my assumptions. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13628|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13931&action=edit [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13578|0 |1 is obsolete| | Attachment #13627|0 |1 is obsolete| | Attachment #13931|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14668&action=edit Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14669&action=edit Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14670&action=edit Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Amended patch: - add use Modern::Perl; in reports/guided_reports.pl - remove a simple-quote string in guided_reports_start.tt Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2699 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan - could you rebase? I started looking into this, but I think better you resolve. Will then test this next. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14668|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16241&action=edit [SIGNED-OFF] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14669|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16244&action=edit [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14670|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16246&action=edit [SIGNED-OFF] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Found a little something: When limiting to subgroups the limit seems to do a truncated search: STH = Something STHE = Something Else Limiting on STHE worked perfectly, limiting on STH still gives me all reports for STH and STHE. Can be dealt with in a follow-up patch. Continuing testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16270&action=edit Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16271&action=edit Bug 9117 [Follow-up] Translatable string should be in double quotes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Large patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16241|0 |1 is obsolete| | Attachment #16244|0 |1 is obsolete| | Attachment #16246|0 |1 is obsolete| | Attachment #16270|0 |1 is obsolete| | Attachment #16271|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16282&action=edit [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16283&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16283|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16284&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16285&action=edit [PASSED QA] Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16286&action=edit [PASSED QA] Bug 9117 [Follow-up] Translatable string should be in double quotes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: - Created several reports fresh and using the new duplicate feature. - Verified authorized values were created correctly and can be viewed from Administration > authorized values. - Checked tabs and limiting on subgroups works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16282|0 |1 is obsolete| | Attachment #16284|0 |1 is obsolete| | Attachment #16285|0 |1 is obsolete| | Attachment #16286|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16287&action=edit [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16288&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16288|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16290&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16292&action=edit [PASSED QA] Bug 9117: Reports hierarchies management improvements - Filter by groups using tabs - Filter by subgroups using a dropdown list under each tab - Allow to create new group and subgroups when building a new report or editing an existing report (no need to go through admin AV interface) + Possibility to duplicate a report (new link in the table) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16293&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch corrects serveral markup errors in the template introduced by this bug as well as previous patches: unescaped ampersands, missing closing tags, typos. To test, view various stages of the process of viewing or creating guided reports and check the source for validity. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16293|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16294&action=edit [PASSED QA] Bug 9117 [Follow-up] Reports hierarchies management improvements This patch avoid javascript bugs when user hasn't 'create_reports' permission (last column is hidden in this case but <th> remains) + fix a typo 'selelcted' > 'selected' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16295&action=edit [PASSED QA] Bug 9117 [Follow-up] Fix group and subgroup filtering When a group code is contained in another group code (e.g. 'COD' and 'CODE'), filtering on the longest ('CODE') include reports of the smallest ('COD'). Same problem for the subgroups. This patch fixes this. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16296&action=edit [PASSED QA] Bug 9117 [Follow-up] Translatable string should be in double quotes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass. Tests done: - Created several reports fresh and using the new duplicate feature. - Verified authorized values were created correctly and can be viewed from Administration > authorized values. - Checked tabs and limiting on subgroups works correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16293|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #33 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- We need a unit test for C4::Koha::AddAuthorisedValue. Once one is provided, please set this patch back to "Passed QA." As an aside, making all the authorised value adding bits of code use the same AddAuthorisedValue subroutine might be good. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16653&action=edit Bug 9117: Add imageurl to the list of parameters of AddAuthorisedValue and add unit test in t/db_dependant/Koha.t -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #35 from Julian Maurice <julian.maurice@biblibre.com> --- To integrate well with other unit tests, I had to add imageurl parameter to AddAuthorisedValue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #35)
To integrate well with other unit tests, I had to add imageurl parameter to AddAuthorisedValue
Thanks. I dislike the use of ok() for this sort of test on principle, but as it was already there and the tests pass perfectly with the introduction of the new routine, I am satisfied with this follow-up and will be pushing this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #37 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9117 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12213 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org