[Bug 28988] New: Reindent calendar template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Bug ID: 28988 Summary: Reindent calendar template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 28963 I would like to update the calendar template so that it has consistent indentation. It also needs to have some trailing spaces removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 [Bug 28963] Use Flatpickr on calendar page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28963 | Blocks| |28963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28963 [Bug 28963] Use Flatpickr on calendar page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124720&action=edit Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124721&action=edit Bug 29899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124720|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 124817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124817&action=edit Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124721|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 124818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124818&action=edit Bug 29899: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=28988 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124817|0 |1 is obsolete| | Attachment #124818|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125318&action=edit Bug 28988: Reindent calendar template This patch performs general template cleanup to the calendar template: Make indentation consistent and trim trailing whitespace. To test, apply the patch and go to Tools -> Calendar. The page should look correct and work correctly. If you view the diff while ignoring whitespace the only changes should be where line breaks were introduced. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 125319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125319&action=edit Bug 28988: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. https://bugs.koha-community.org/show_bug.cgi?id=28988 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed the bug number on the follow-up patch. Something spotted while testing: we have a really heavy grey border around the options for adding/editing a calendar entry that doesn't quite fit with the background. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Unfortunately there are several accessibility patches in the queue currently that are modifying this template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #8)
Unfortunately there are several accessibility patches in the queue currently that are modifying this template.
I've tried to move Bug 27631 along (Accessibility: Staff Client - <h1> on each page is Logo but should be page description/title). I rebased and signed off on the existing patches and submitted a follow-up that addresses the concerns which led me to mark it Failed QA. Other patches in that series don't apply anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe that the heading issue on the accessilibity patch set would not be a difficult one to fix if we pushed this first, so I'd say let's move forward with this and flatpickr for now. Both accessibility and the date widget switch are things we want to push forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28988 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org