[Bug 36054] New: Setting MARC 005 as not required causes save error in Advanced Editor and not Basic Editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Bug ID: 36054 Summary: Setting MARC 005 as not required causes save error in Advanced Editor and not Basic Editor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: esther.melander@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This requires having some bib records where the 005 is blank or missing. To recreate: 1. Edit the default framework and uncheck the mandatory box for the 005 and save. 2. Find a bib record with a missing/blank 005 and edit the record in the basic editor. 3. See that the 005 is blank and is not required. Save The record saves as it should. 4. Now edit the record again and switch to the Advanced Editor. 5. See that the 005 is missing. 6. Save. Save fails and gives an error statement "Record structure invalid, cannot save." Ideally records should have a 005. If this is a truly required field for Koha to function, then the ability to mark the field not mandatory should be disabled. Along with this, the ability to delete the field should be prevented (see bug 35135). Regardless, this is inconsistent behavior where it works in one place and not another. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please see bug 35993. This should ensure that we always store 005 in new or modified records. (Note that most records without 005 are coming from ACQ.) I guess that it will also resolve this bug. Apart from that, you might wanna insert 005 in all catalogue records where it is missing. touch_all_biblios or some smarter approach? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35993 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 --- Comment #2 from Esther Melander <esther.melander@bywatersolutions.com> --- Missing 005's are also happening with migrated dated or large batch imports. Yes, touch all biblios can fix the missing 005. Does bug 35993 prevent the ability to delete the tag in the framework configuration or allow the tag to not be marked mandatory? Perhaps indirectly. It may be helpful to make the control tags more explicitly required in frameworks, in general. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Esther Melander from comment #2)
Missing 005's are also happening with migrated dated or large batch imports.
These also go via AddBiblio and ModBiblio. So should be fine with 35993.
Does bug 35993 prevent the ability to delete the tag in the framework configuration or allow the tag to not be marked mandatory? Perhaps indirectly. It may be helpful to make the control tags more explicitly required in frameworks, in general.
No, thats not in the scope of 35993. You might open a new report for it. But note that it does not matter much for 005 now actually. It will be updated always regardless of editor settings. But would be good to not allow what you say. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Esther Melander from comment #0)
This requires having some bib records where the 005 is blank or missing.
To recreate: 1. Edit the default framework and uncheck the mandatory box for the 005 and save.
For this step, to get the described behavior, you must have unchecked the mandatory box for 005's single subfield, @, rather than the mandatory box for 005 itself. In general in the basic editor, a mandatory field without any mandatory subfield means "Field nnn is mandatory, at least one of its subfields must be filled" even if it only has one defined subfield, but it makes an exception for control fields, and treats a mandatory control field without the @ subfield as mandatory as being... not mandatory. That makes no sense. In the advanced editor, a mandatory field without any mandatory subfields means that you must have the field, and because you can't have a field with no subfields, you must have a subfield, so if 005 is mandatory you have to have it and the only subfield it has. Going the other way, making 005 not mandatory but its only subfield mandatory, would have put you in the difference between bug 25962 and bug 32722 since the advanced editor thinks mandatory subfield in non-mandatory tag means it's mandatory only if you add the field, and the basic editor thinks the subfield is mandatory and since you have no way to remove the tag, that means both are mandatory, so you would have been able to save in the advanced editor but not the basic editor. Unchecking both just works: both editors will save without error if you don't touch it, both will add it if you choose to, and once bug 35993 lands both will create it when you save without it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26820 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Bug 26820 was about the way that the mandatory/important framework flags are ignored at the field level for 000-009, though it didn't quite realize it at first. Rather than a duplicate, it wouldn't be unreasonable to make this dependent on bug 35993 and then stop shipping frameworks with 005 as mandatory, since with bug 35993 it will be filled out no matter what you do or don't do with it (and whatever you do with it will be overwritten, but having one read-only field just because it will be overwritten seems excessive). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35993 Summary|Setting MARC 005 as not |Don't mark MARC21 005 as |required causes save error |mandatory in frameworks now |in Advanced Editor and not |that AddBiblio and |Basic Editor |ModBibilio will set it no | |matter what Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 [Bug 35993] AddBiblio should add 005 just like ModBiblio updates it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 --- Comment #6 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167588&action=edit Bug 36054: Don't mark MARC21 005 as mandatory in frameworks now that AddBiblio and ModBibilio will set it no matter what With bug 35993, both AddBiblio and ModBiblio will add a missing 005 or update an existing 005 to the current timestamp. That makes setting it as mandatory in bib frameworks pointless: whether you remove it, blank it, or set it, what you do doesn't matter because it will be set, and set to something different than what you set. Test plan: 1. Apply patch, reset_all 2. Administration - MARC bibliographic framework 3. In the Default framework row, Actions - MARC structure 4. In the 005 row, verify the Mandatory column says No 5. 005 row, Actions - View subfields 6. For the @ subfield, verify constraints says Not mandatory Extra credit: Set EnableAdvancedCatalogingEditor to Enable and in both editors try to save a record without a 005 or with one set to your choice of value, and then in the MARC preview verify that no matter what there is always a 005 with a value other than yours. Bonus for exporting a record, editing it with an external editor to remove the 005, reimporting it, and verifying that the imported record has a 005. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phil@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Bug 36054 depends on bug 35993, which changed state. Bug 35993 Summary: AddBiblio should add 005 just like ModBiblio updates it https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35993 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167588|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172102&action=edit Bug 36054: Don't mark MARC21 005 as mandatory in frameworks now that AddBiblio and ModBibilio will set it no matter what With bug 35993, both AddBiblio and ModBiblio will add a missing 005 or update an existing 005 to the current timestamp. That makes setting it as mandatory in bib frameworks pointless: whether you remove it, blank it, or set it, what you do doesn't matter because it will be set, and set to something different than what you set. Test plan: 1. Apply patch, reset_all 2. Administration - MARC bibliographic framework 3. In the Default framework row, Actions - MARC structure 4. In the 005 row, verify the Mandatory column says No 5. 005 row, Actions - View subfields 6. For the @ subfield, verify constraints says Not mandatory Extra credit: Set EnableAdvancedCatalogingEditor to Enable and in both editors try to save a record without a 005 or with one set to your choice of value, and then in the MARC preview verify that no matter what there is always a 005 with a value other than yours. Bonus for exporting a record, editing it with an external editor to remove the 005, reimporting it, and verifying that the imported record has a 005. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172102|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172115&action=edit Bug 36054: Don't mark MARC21 005 as mandatory in frameworks now that AddBiblio and ModBibilio will set it no matter what With bug 35993, both AddBiblio and ModBiblio will add a missing 005 or update an existing 005 to the current timestamp. That makes setting it as mandatory in bib frameworks pointless: whether you remove it, blank it, or set it, what you do doesn't matter because it will be set, and set to something different than what you set. Test plan: 1. Apply patch, reset_all 2. Administration - MARC bibliographic framework 3. In the Default framework row, Actions - MARC structure 4. In the 005 row, verify the Mandatory column says No 5. 005 row, Actions - View subfields 6. For the @ subfield, verify constraints says Not mandatory Extra credit: Set EnableAdvancedCatalogingEditor to Enable and in both editors try to save a record without a 005 or with one set to your choice of value, and then in the MARC preview verify that no matter what there is always a 005 with a value other than yours. Bonus for exporting a record, editing it with an external editor to remove the 005, reimporting it, and verifying that the imported record has a 005. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change makes the 005 release notes| |tag in MARC bibliographic | |frameworks no longer | |mandatory, because every | |time a bibliographic record | |is added or modified, Koha | |will set the content of 005 | |to the current time. | |Existing installations are | |not affected by this | |change, but should feel | |free to make the same | |change to their installed | |frameworks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36054 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Individual fields are not documented in the manual, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org