[Bug 26421] New: Use Bootstrap screen reader text class for shelf browser messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Bug ID: 26421 Summary: Use Bootstrap screen reader text class for shelf browser messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 26039 Bug 26039 added some text intended only for screen reader users. Since the Bootstrap 4 upgrade this text is shown because the CSS class is obsolete. I propose to replace the use of the "hidden" class with "sr-only." https://getbootstrap.com/docs/4.5/utilities/screen-readers/ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26039 [Bug 26039] Accessibility: Shelf browser is not announced upon loading -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 109829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109829&action=edit Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 26446 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109829|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110058&action=edit Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Stina Hallin <stina.hallin@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stina.hallin@ub.lu.se --- Comment #4 from Stina Hallin <stina.hallin@ub.lu.se> --- Screen reader announced the text as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110058|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110117&action=edit Bug 26421: Use Bootstrap screen reader text class for shelf browser messages This patch udpates the markup added by Bug 26039, replacing the "hidden" class, which is no longer functional with Bootstrap 4, with "sr-only," a class designed specifically for screen reader text. The patch also corrects a typo, "shelfbrowers" -> "shelf browser" To test, apply the patch and make sure the OPACShelfBrowser system preference is enabled. View the detail page for a bibliographic record with items. In the holdings table, you should see links labeled "Browse shelf." When you open the shelf browser there should be a link at the top that reads "Close shelf browser." If you have access to a screen reader, test that the hidden text is announced by the reader. "Browse shelf (Opens below)" and "Close shelf browser (Hides shelf browser)." Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 [Bug 29128] Trailing in whitespace in Browse shelf link on opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org