[Bug 5243] New: C4::Search::SimpleSearch call in AuthoritiesMarc.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Summary: C4::Search::SimpleSearch call in AuthoritiesMarc.pm Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com Estimated Hours: 0.0 In 3.2 beta : AuthoritiesMarc.pm fails because of external function call : my ($error, $results, $total_hits)=SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); SimpleSearch is a function of C4/Search.pm so it must be : my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0, 1, [ "authorityserver" ] ); -- You may see that a correct call is made line 363. Regards. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-09-23 10:31:14 UTC --- Created attachment 2644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2644 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> 2010-10-27 23:38:09 UTC --- Is this happening in 3.2.0? Your proposed patch won't hurt anything, but it shouldn't be necessary since C4::Search exports SimpleSearch by default. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-28 07:38:47 UTC --- (In reply to comment #2)
Is this happening in 3.2.0? Your proposed patch won't hurt anything, but it shouldn't be necessary since C4::Search exports SimpleSearch by default.
Yes it is present in 3.2.0. When I create a new authority, I have this message : Undefined subroutine &C4::AuthoritiesMarc::SimpleSearch called at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 902. I noticed that the full method is present line 362 : my ($err,$res,$result) = C4::Search::SimpleSearch($query,0,10); So why make it different at line 902 ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2644|0 |1 is obsolete| | --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-28 07:46:00 UTC --- Created attachment 2704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2704 Proposed patch (3.2.0) Updated for 3.2.0 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> 2010-10-28 12:10:51 UTC --- Must be something peculiar to your setup - as I said, works for me. Since, as I also said, it doesn't hurt anything to add 'C4::Search::' to the function call, I've submitted your patch with my signoff. Thanks! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-28 12:43:57 UTC --- (In reply to comment #5)
Must be something peculiar to your setup - as I said, works for me. Since, as I also said, it doesn't hurt anything to add 'C4::Search::' to the function call, I've submitted your patch with my signoff. Thanks!
I'm using Debian Squeeze, maybe it's the reason. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-02 04:25:19 UTC --- Pushed, please test and close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-11-02 09:18:14 UTC --- Ok,perfect Link to commit : http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=9bd16d23b24d... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 --- Comment #9 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-18 03:15:16 UTC --- This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5243 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED --- Comment #10 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-11-18 09:33:09 UTC --- Closed. End of story. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org